fix: support history_stats and mold_indicator helpers in ha_config_set_helper (#2206)

HA's Helpers UI has offered config flows for history_stats (since 2024.7) and mold_indicator, but the flow-helper enum was never re-audited after #324, so ha_config_set_helper rejected both at schema validation. Adds both to the flow-helper lists and mirrored literals, documents the deliberate otp exclusion (TOTP confirm step) with routing to ha_set_integration, and adds e2e lifecycle tests. Fixes #2187

Author: kingpanther13

src/ha_mcp/server.py

@@ -603,14 +603,15 @@ def _apply_settings_visibility(self) -> None:
             "conditions actions get show detail"
         ),
         # s09: "create helper" → ha_config_set_helper should outrank remove_helper
-        # Covers all 27 helper types (12 simple + 15 flow-based, unified in #967).
+        # Covers all 29 helper types (12 simple + 17 flow-based, unified in #967).
         "ha_config_set_helper": (
             "create update new add helper "
             "input_boolean input_button input_number input_text input_datetime "
             "input_select counter timer schedule zone person tag "
             "template group utility_meter derivative min_max threshold "
             "integration statistics trend random filter tod "
-            "generic_thermostat switch_as_x generic_hygrostat"
+            "generic_thermostat switch_as_x generic_hygrostat "
+            "history_stats mold_indicator"
         ),
         # Boost tools that compete with ha_search for common queries
         "ha_config_get_script": (

src/ha_mcp/settings_ui/locales/zh-Hans.json

@@ -608,7 +608,7 @@
     },
     "ha_config_set_helper": {
       "title": "创建或更新辅助实体",
-      "description": "创建或更新 Home Assistant 辅助实体与配置子条目（28 种类型，统一接口）。"
+      "description": "创建或更新 Home Assistant 辅助实体与配置子条目（30 种类型，统一接口）。"
     },
     "ha_config_set_label": {
       "title": "创建或更新标签",

src/ha_mcp/tools/config_entry_flow.py

@@ -7,7 +7,7 @@
 
 The create/update entry point is the unified ha_config_set_helper tool in
 tools_config_helpers.py, which routes to create_flow_helper / update_flow_helper
-for the 15 helper types listed in FLOW_HELPER_TYPES.
+for the 17 helper types listed in FLOW_HELPER_TYPES.
 
 The same flow walkers drive every other config-entry surface, not just
 helpers: ``ha_set_integration`` creates entries for arbitrary domains through
@@ -65,7 +65,10 @@ def _reject_redaction_sentinels(config_dict: dict[str, Any]) -> None:
         )
 
 
-# 15 helpers that use Config Entry Flow API (Issue #324).
+# 17 helpers that use Config Entry Flow API (Issue #324, #2187).
+# `otp` is the one helper-typed config flow deliberately left out: its confirm
+# step demands a live TOTP code derived from the secret, which no flow walker
+# can supply. It stays reachable through ha_set_integration(domain="otp").
 SUPPORTED_HELPERS = Literal[
     "template",
     "group",
@@ -82,6 +85,8 @@ def _reject_redaction_sentinels(config_dict: dict[str, Any]) -> None:
     "generic_thermostat",
     "switch_as_x",
     "generic_hygrostat",
+    "history_stats",
+    "mold_indicator",
 ]
 
 # Value-set form of SUPPORTED_HELPERS for runtime routing checks.
@@ -103,6 +108,8 @@ def _reject_redaction_sentinels(config_dict: dict[str, Any]) -> None:
         "generic_thermostat",
         "switch_as_x",
         "generic_hygrostat",
+        "history_stats",
+        "mold_indicator",
     }
 )
 

src/ha_mcp/tools/tools_config_helpers.py

@@ -4398,6 +4398,7 @@ async def ha_config_set_helper(
                 "generic_hygrostat",
                 "generic_thermostat",
                 "group",
+                "history_stats",
                 "input_boolean",
                 "input_button",
                 "input_datetime",
@@ -4406,6 +4407,7 @@ async def ha_config_set_helper(
                 "input_text",
                 "integration",
                 "min_max",
+                "mold_indicator",
                 "person",
                 "random",
                 "schedule",
@@ -4702,7 +4704,8 @@ async def ha_config_set_helper(
                     "helper_type='config_subentry' "
                     "(template, group, utility_meter, derivative, min_max, threshold, "
                     "integration, statistics, trend, random, filter, tod, "
-                    "generic_thermostat, switch_as_x, generic_hygrostat). "
+                    "generic_thermostat, switch_as_x, generic_hygrostat, "
+                    "history_stats, mold_indicator). "
                     "Ignored for simple helper types. "
                     "Field set is delivered as data_schema on the first validation error."
                 ),
@@ -4739,7 +4742,7 @@ async def ha_config_set_helper(
     ) -> dict[str, Any]:
         """
         Create or update Home Assistant helper entities and config subentries
-        (28 types, unified interface).
+        (30 types, unified interface).
 
         MUST call ha_get_skill_guide OR refer to your locally installed skills first.
 
@@ -4753,9 +4756,13 @@ async def ha_config_set_helper(
 
         FLOW types (pass `config` dict, Config Entry Flow API): template, group,
         utility_meter, derivative, min_max, threshold, integration, statistics, trend,
-        random, filter, tod, generic_thermostat, switch_as_x, generic_hygrostat.
+        random, filter, tod, generic_thermostat, switch_as_x, generic_hygrostat,
+        history_stats, mold_indicator.
         Note: `tod` is the purpose-built "is-current-time-in-range" indicator
         (supports cross-midnight ranges, unlike `schedule`).
+        Note: `otp` is a helper in the HA UI but is not offered here — its flow
+        requires a live TOTP code. Create it with ha_set_integration(domain="otp"),
+        as with any other helper-domain flow outside this list.
 
         CONFIG_SUBENTRY type (Config Subentry Flow API): config_subentry.
         Pass `entry_id`, `subentry_type`, and `config`. Pass `subentry_id` to

src/ha_mcp/tools/tools_integrations.py

@@ -104,7 +104,7 @@
     "tag",
     # config-entry subentries
     "config_subentry",
-    # 15 FLOW
+    # 17 FLOW
     "template",
     "group",
     "utility_meter",
@@ -120,6 +120,8 @@
     "generic_thermostat",
     "switch_as_x",
     "generic_hygrostat",
+    "history_stats",
+    "mold_indicator",
 ]
 assert set(get_args(HelperTypeLiteral)) == (
     SIMPLE_HELPER_TYPES | FLOW_HELPER_TYPES | {"config_subentry"}
@@ -1846,7 +1848,9 @@ async def ha_set_integration(
 
         WHEN NOT TO USE:
         - Helpers (template, group, utility_meter, ...): use
-          ha_config_set_helper.
+          ha_config_set_helper. The exception is `otp`, which is a helper in
+          the HA UI but is created HERE via domain="otp" — its flow needs a
+          live TOTP code, so ha_config_set_helper deliberately omits it.
         - Config subentries: use
           ha_config_set_helper(helper_type='config_subentry').
         - Removing an entry: use ha_remove_helpers_integrations.
@@ -2110,10 +2114,10 @@ async def ha_remove_helpers_integrations(
         - SIMPLE (12, websocket-delete): input_button, input_boolean,
           input_select, input_number, input_text, input_datetime, counter,
           timer, schedule, zone, person, tag.
-        - FLOW (15, config-entry-delete via entity lookup): template, group,
+        - FLOW (17, config-entry-delete via entity lookup): template, group,
           utility_meter, derivative, min_max, threshold, integration,
           statistics, trend, random, filter, tod, generic_thermostat,
-          switch_as_x, generic_hygrostat.
+          switch_as_x, generic_hygrostat, history_stats, mold_indicator.
 
         ROUTING:
         - SIMPLE helper_type + bare helper_id or entity_id → websocket delete.

src/ha_mcp/tools/tools_yaml_config.py

@@ -403,7 +403,7 @@ async def ha_config_set_yaml(
         - Automations (storage-mode) -> ha_config_set_automation
         - Scripts (storage-mode) -> ha_config_set_script
         - Scenes (storage-mode) -> ha_config_set_scene
-        - All 28 helper types (input_*, counter, timer, schedule, zone, person,
+        - All 30 helper types (input_*, counter, timer, schedule, zone, person,
           tag, group, min_max, threshold, derivative, statistics, utility_meter,
           trend, filter, switch_as_x, etc.) -> ha_config_set_helper
 

tests/initial_test_state/configuration.yaml

@@ -74,4 +74,14 @@ template:
         state: "{{ 10.0 }}"
         device_class: temperature
         state_class: measurement
-        unit_of_measurement: "°C"
+        unit_of_measurement: "°C"
+      # mold_indicator's flow requires a humidity source alongside the two
+      # temperature ones. HA's EntitySelector validates only the entity_id
+      # shape, so a temperature sensor would be accepted here and then log
+      # "unsupported unit" and hold the helper at unknown forever.
+      - name: demo Humidity
+        unique_id: e2e_demo_humidity
+        state: "{{ 45.0 }}"
+        device_class: humidity
+        state_class: measurement
+        unit_of_measurement: "%"