test(e2e): remove #1389 cadence-measurement infra retired by this refactor

The #1389/#1398 work added an e2e test
(``test_poll_cadence_measurement.py``) plus xdist plumbing in
``tests/src/e2e/conftest.py`` (``record_poll_cadence_measurement``,
``_POLL_CADENCE_MEASUREMENTS`` + xdist worker handoff, terminal-summary
section) to empirically validate ``_POLL_CADENCE``'s p50/p99/worst
percentiles. That test consumed the ``entity-registration-elapsed``
DEBUG log line emitted by ``_poll_for_automation_entity`` on each
successful registration.

This PR removes both ``_POLL_CADENCE`` and the elapsed-time
instrumentation: the cadence loop is replaced by the WS event-driven
discovery helper, which resolves sub-second on the happy path without
any cadence tuning needed. The measurement test is therefore consuming
a log signal that no longer exists — CI fail signature is "No
'entity-registration-elapsed' DEBUG records captured after 10
automation creations."

Deletes:

- ``tests/src/e2e/workflows/automation/test_poll_cadence_measurement.py``
  (207 lines) — entire test file. The cadence tuple it validates is
  gone.
- ``record_poll_cadence_measurement()`` + ``_POLL_CADENCE_MEASUREMENTS``
  / ``_ALL_POLL_CADENCE_MEASUREMENTS`` + xdist worker handoff in
  ``pytest_sessionfinish`` / ``pytest_testnodedown`` + the
  ``#1389 _POLL_CADENCE measurement`` terminal section in
  ``pytest_terminal_summary``.

Also updates the ``NOT_VERIFIED_WARNING_PREFIX`` comment in
``tools_config_automations.py`` from "exhausts ``_POLL_CADENCE``" to
"exhausts its budget (``_POLL_BUDGET_S``)" and drops the test-file
reference, since the test that consumed the export is gone.

Per Patch76's #1406 review note: "the deletion wins" — extending that
to the e2e measurement infra that consumed the deleted instrumentation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: kingpanther13

src/ha_mcp/tools/tools_config_automations.py

@@ -56,11 +56,10 @@
 
 # Distinctive prefix of the soft-failure warning emitted by
 # ``ha_config_set_automation`` when ``_poll_for_automation_entity``
-# exhausts ``_POLL_CADENCE`` without matching the new automation.
-# Exported so tests (e.g. ``test_poll_cadence_measurement.py``) can
-# detect a missed registration without hard-coding the literal —
-# rewording the warning becomes a compile-time coupling rather than
-# a silent test drift.
+# exhausts its budget (``_POLL_BUDGET_S``) without resolving the new
+# automation's entity_id. Exported so future tests can detect a missed
+# registration without hard-coding the literal — rewording the warning
+# becomes a compile-time coupling rather than a silent test drift.
 NOT_VERIFIED_WARNING_PREFIX = (
     "Automation was submitted to Home Assistant but the entity was not found"
 )

tests/src/e2e/conftest.py

@@ -89,21 +89,6 @@
 _READINESS_TIMINGS: list[dict[str, Any]] = []
 _ALL_READINESS_TIMINGS: list[dict[str, Any]] = []
 
-# Parallel channel for the #1389 ``_POLL_CADENCE`` measurement —
-# mirrors the xdist round-trip used by ``_READINESS_TIMINGS`` above.
-_POLL_CADENCE_MEASUREMENTS: list[dict[str, Any]] = []
-_ALL_POLL_CADENCE_MEASUREMENTS: list[dict[str, Any]] = []
-
-
-def record_poll_cadence_measurement(measurement: dict[str, Any]) -> None:
-    """Record a single #1389 measurement run from a test method.
-
-    See the call site in
-    ``workflows/automation/test_poll_cadence_measurement.py`` for the
-    measurement dict shape — that file owns the schema.
-    """
-    _POLL_CADENCE_MEASUREMENTS.append(measurement)
-
 
 def _log_readiness_timing(gate: str, elapsed_s: float, **extras: Any) -> None:
     """Record a fixture-side readiness-gate timing data point.
@@ -193,8 +178,6 @@ def pytest_sessionfinish(session, exitstatus):
     workeroutput = getattr(session.config, "workeroutput", None)
     if workeroutput is not None and _READINESS_TIMINGS:
         workeroutput["readiness_timings"] = list(_READINESS_TIMINGS)
-    if workeroutput is not None and _POLL_CADENCE_MEASUREMENTS:
-        workeroutput["poll_cadence_measurements"] = list(_POLL_CADENCE_MEASUREMENTS)
 
 
 def pytest_testnodedown(node, error):
@@ -206,9 +189,6 @@ def pytest_testnodedown(node, error):
     """
     workeroutput = getattr(node, "workeroutput", {})
     _ALL_READINESS_TIMINGS.extend(workeroutput.get("readiness_timings", []))
-    _ALL_POLL_CADENCE_MEASUREMENTS.extend(
-        workeroutput.get("poll_cadence_measurements", [])
-    )
 
 
 def pytest_terminal_summary(terminalreporter, exitstatus, config):
@@ -251,24 +231,6 @@ def pytest_terminal_summary(terminalreporter, exitstatus, config):
             f"follow-up gate justified."
         )
 
-    # #1389 _POLL_CADENCE measurement section — same xdist-aware plumbing
-    # as the readiness gates above. Falls back to the local list when running
-    # without xdist (no ``pytest_testnodedown`` fires in that mode).
-    poll_measurements = _ALL_POLL_CADENCE_MEASUREMENTS or _POLL_CADENCE_MEASUREMENTS
-    if poll_measurements:
-        terminalreporter.section("#1389 _POLL_CADENCE measurement")
-        for m in poll_measurements:
-            terminalreporter.write_line(
-                f"[POLL_CADENCE_1389] N={m['n']}/{m.get('attempts', m['n'])} "
-                f"p50={m['p50']:.1f}ms p90={m['p90']:.1f}ms "
-                f"worst={m['worst']:.1f}ms "
-                f"min={m['min']:.1f}ms max={m['max']:.1f}ms "
-                f"not_verified={m['not_verified']} VERDICT={m['verdict']}"
-            )
-            terminalreporter.write_line(
-                f"[POLL_CADENCE_1389] samples_ms={m['samples']}"
-            )
-
 
 def _is_missing_column_or_table_error(exc: sqlite3.OperationalError) -> bool:
     """Return True only for benign 'schema drift' errors (column/table missing).