Commit ffd3e66
Address review-toolkit findings on install-windows.ps1
- Drop the inaccurate "Windows Sandbox" example in the fallback comment;
the Appx module ships in the default Sandbox image. Replace with the
cases that actually break Get-AppxPackage: Constrained Language Mode
under WDAC/AppLocker, Server Core / Nano installs.
- Drop the unverifiable "for days" claim on stale package folders. The
asynchronous-cleanup behavior is real but no published bound exists,
and the next sentence already justifies the hardening.
- Tighten the leading comment block — "different installers write to
different roots" was borderline WHAT-explanation.
- Bump the "Detected:" line to Cyan and echo the resolved $ConfigDir on
the next line so users can sanity-check the actual path before the
installer writes the config. White-on-default got lost in the rest of
the script's output, defeating the point of the line.
- Drop a dead try/catch{} around `Get-Command uvx -ErrorAction
SilentlyContinue`. The cmdlet's SilentlyContinue already handles
"not found"; the catch could only fire on terminating errors and
silently swallow them, leaving the user with no signal.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 728809b commit ffd3e66
1 file changed
Lines changed: 11 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
13 | 11 | | |
14 | 12 | | |
15 | 13 | | |
| |||
20 | 18 | | |
21 | 19 | | |
22 | 20 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
27 | 25 | | |
28 | 26 | | |
29 | 27 | | |
| |||
46 | 44 | | |
47 | 45 | | |
48 | 46 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 47 | + | |
53 | 48 | | |
54 | 49 | | |
55 | 50 | | |
| |||
72 | 67 | | |
73 | 68 | | |
74 | 69 | | |
75 | | - | |
| 70 | + | |
| 71 | + | |
76 | 72 | | |
77 | 73 | | |
78 | 74 | | |
| |||
0 commit comments