Skip to content

Commit 31725f8

Browse files
author
V8 Disassembler Builder
committed
Restore Android d8 artifact packaging
1 parent 7279748 commit 31725f8

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

.github/workflows/build-v8dasm.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ jobs:
182182
path: |
183183
v8/v8/v8dasm-${{ matrix.version.v8 }}-android-arm64
184184
v8/v8/d8-${{ matrix.version.v8 }}-android-arm64
185-
v8/v8/d8-${{ matrix.version.v8 }}-android-arm64.map
186185
retention-days: 30
187186

188187
release:
@@ -212,7 +211,7 @@ jobs:
212211
if [ -f v8dasm-${version}.exe ]; then
213212
zip ../../release/${platform}-${version}.zip v8dasm-${version}.exe
214213
elif [ -f v8dasm-${version}-android-arm64 ]; then
215-
zip ../../release/${platform}-${version}.zip v8dasm-${version}-android-arm64 d8-${version}-android-arm64 d8-${version}-android-arm64.map
214+
zip ../../release/${platform}-${version}.zip v8dasm-${version}-android-arm64 d8-${version}-android-arm64
216215
elif [ -f v8dasm-${version} ]; then
217216
zip ../../release/${platform}-${version}.zip v8dasm-${version}
218217
fi

scripts/v8dasm-builders/build-android-arm64.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ GN
152152
fi
153153

154154
echo "=====[ Configuring V8 Build for Android ARM64 ]====="
155-
GN_ARGS='target_os="android" target_cpu="arm64" v8_target_cpu="arm64" is_component_build=false is_debug=false v8_monolithic=true v8_static_library=true v8_enable_disassembler=true v8_enable_object_print=true v8_use_external_startup_data=false v8_enable_pointer_compression=false v8_enable_sandbox=false v8_enable_31bit_smis_on_64bit_arch=false v8_enable_short_builtin_calls=false dcheck_always_on=false symbol_level=0 v8_android_log_stdout=true extra_ldflags="-Wl,-Map=d8.map"'
155+
GN_ARGS='target_os="android" target_cpu="arm64" v8_target_cpu="arm64" is_component_build=false is_debug=false v8_monolithic=true v8_static_library=true v8_enable_disassembler=true v8_enable_object_print=true v8_use_external_startup_data=false v8_enable_pointer_compression=false v8_enable_sandbox=false v8_enable_31bit_smis_on_64bit_arch=false v8_enable_short_builtin_calls=false dcheck_always_on=false symbol_level=0 v8_android_log_stdout=true'
156156

157157
if [ -n "$BUILD_ARGS" ]; then
158158
GN_ARGS="$GN_ARGS $BUILD_ARGS"
@@ -171,16 +171,13 @@ chmod +x "$OUTPUT_NAME"
171171
D8_OUTPUT_NAME="d8-$V8_VERSION-android-arm64"
172172
cp out.gn/android_arm64.release/d8 "$D8_OUTPUT_NAME"
173173
chmod +x "$D8_OUTPUT_NAME"
174-
cp out.gn/android_arm64.release/d8.map "$D8_OUTPUT_NAME.map"
175174

176-
if [ -f "$OUTPUT_NAME" ] && [ -f "$D8_OUTPUT_NAME" ] && [ -f "$D8_OUTPUT_NAME.map" ]; then
175+
if [ -f "$OUTPUT_NAME" ] && [ -f "$D8_OUTPUT_NAME" ]; then
177176
echo "=====[ Build Successful ]====="
178177
ls -lh "$OUTPUT_NAME"
179178
ls -lh "$D8_OUTPUT_NAME"
180-
ls -lh "$D8_OUTPUT_NAME.map"
181179
file "$OUTPUT_NAME"
182180
file "$D8_OUTPUT_NAME"
183-
file "$D8_OUTPUT_NAME.map"
184181
echo "Built: $V8_DIR/$OUTPUT_NAME"
185182
echo "Built: $V8_DIR/$D8_OUTPUT_NAME"
186183
else

0 commit comments

Comments
 (0)