add fuzz and mocks, fix security findings

Author: hougangdev

foundry.toml

@@ -8,4 +8,6 @@ remappings = [
     "@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts/"
 ]
 
+# Use: forge coverage --no-match-coverage "test/mocks/" to exclude mocks
+
 # See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options

report.md

@@ -0,0 +1,76 @@
+# Aderyn Analysis Report
+
+This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a static analysis tool built by [Cyfrin](https://cyfrin.io), a blockchain security company. This report is not a substitute for manual audit or security review. It should not be relied upon for any purpose other than to assist in the identification of potential security vulnerabilities.
+# Table of Contents
+
+- [Summary](#summary)
+  - [Files Summary](#files-summary)
+  - [Files Details](#files-details)
+  - [Issue Summary](#issue-summary)
+- [Low Issues](#low-issues)
+  - [L-1: Centralization Risk for trusted owners](#l-1-centralization-risk-for-trusted-owners)
+
+
+# Summary
+
+## Files Summary
+
+| Key | Value |
+| --- | --- |
+| .sol Files | 1 |
+| Total nSLOC | 84 |
+
+
+## Files Details
+
+| Filepath | nSLOC |
+| --- | --- |
+| src/LimitOrderBook.sol | 84 |
+| **Total** | **84** |
+
+
+## Issue Summary
+
+| Category | No. of Issues |
+| --- | --- |
+| High | 0 |
+| Low | 1 |
+
+
+# Low Issues
+
+## L-1: Centralization Risk for trusted owners
+
+Contracts have owners with privileged rights to perform admin tasks and need to be trusted to not perform malicious updates or drain funds.
+
+<details><summary>4 Found Instances</summary>
+
+
+- Found in src/LimitOrderBook.sol [Line: 14](src/LimitOrderBook.sol#L14)
+
+	```solidity
+	contract LimitOrderBook is Ownable, ReentrancyGuard {
+	```
+
+- Found in src/LimitOrderBook.sol [Line: 155](src/LimitOrderBook.sol#L155)
+
+	```solidity
+	    function authorizeExecutor(address executor) external onlyOwner {
+	```
+
+- Found in src/LimitOrderBook.sol [Line: 164](src/LimitOrderBook.sol#L164)
+
+	```solidity
+	    function revokeExecutor(address executor) external onlyOwner {
+	```
+
+- Found in src/LimitOrderBook.sol [Line: 173](src/LimitOrderBook.sol#L173)
+
+	```solidity
+	    function setExecutorAuthRequired(bool requireAuth) external onlyOwner {
+	```
+
+</details>
+
+
+

src/LimitOrderBook.sol

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-pragma solidity ^0.8.25;
+pragma solidity 0.8.25;
 
 import "@openzeppelin/contracts/access/Ownable.sol";
 import "@openzeppelin/contracts/utils/ReentrancyGuard.sol";
@@ -21,7 +21,6 @@ contract LimitOrderBook is Ownable, ReentrancyGuard {
     error LimitOrderBook_OrderNotFound();
     error LimitOrderBook_NotOrderOwner();
     error LimitOrderBook_OrderAlreadyExecuted();
-    error LimitOrderBook_OrderNotExecutable();
     error LimitOrderBook_UnauthorizedExecutor();
 
     /*//////////////////////////////////////////////////////////////
@@ -49,11 +48,12 @@ contract LimitOrderBook is Ownable, ReentrancyGuard {
                                 EVENTS
     //////////////////////////////////////////////////////////////*/
 
-    event OrderPlaced(uint256 indexed orderId, address indexed user, uint256 price, uint256 amount);
+    event OrderPlaced(uint256 indexed orderId, address indexed user, uint256 indexed price, uint256 amount);
     event OrderExecuted(uint256 indexed orderId);
     event OrderCancelled(uint256 indexed orderId);
     event ExecutorAuthorized(address indexed executor);
     event ExecutorRevoked(address indexed executor);
+    event ExecutorAuthRequirementChanged(bool indexed requireAuth);
 
     /*//////////////////////////////////////////////////////////////
                                 MODIFIERS
@@ -74,6 +74,8 @@ contract LimitOrderBook is Ownable, ReentrancyGuard {
     //////////////////////////////////////////////////////////////*/
 
     constructor(address initialOwner) Ownable(initialOwner) {
+        // Explicitly initialize state variables
+        s_nextOrderId = 0;
         // Initially, allow anyone to execute (can be changed later)
         // This supports the permissionless bot execution model
         s_authorizedExecutors[address(0)] = true; // Flag to indicate permissionless execution
@@ -171,6 +173,7 @@ contract LimitOrderBook is Ownable, ReentrancyGuard {
     function setExecutorAuthRequired(bool requireAuth) external onlyOwner {
         // Use address(0) as a flag for whether auth is required
         s_authorizedExecutors[address(0)] = !requireAuth;
+        emit ExecutorAuthRequirementChanged(requireAuth);
     }
 
     /*//////////////////////////////////////////////////////////////