device["MpptTransmitError"]["v"] = mpptData.transmissionErrors_Day;

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/VeDirectFrameHandler/VeDirectFrameHandler.cpp`:
- Around line 392-408: The SUM-based halving in
VeDirectFrameHandler<T>::setErrorCounter (which updates _errorCounter and checks
veStruct::Error::SUM > 50000) skews transmissionErrors_Day because the numerator
is reduced but the elapsed-time denominator is not; fix by tracking extra state
(e.g., add a lastScaleTime or cumulativeScaleFactor member) and update how
transmissionErrors_Day is computed to account for the scale: either record the
timestamp when you halve counters and use that as the start time for rate
calculation, or maintain a cumulative scaling divisor applied when computing the
effective total so the daily rate reflects pre-scale counts; update
setErrorCounter to adjust the new state (lastScaleTime or cumulativeScaleFactor)
whenever you downscale so transmissionErrors_Day uses those values to compute an
accurate rate.

---

Nitpick comments:
In `@include/battery/victronsmartshunt/Stats.h`:
- Line 34: The new member float _transmissionErrors is not explicitly
initialized; initialize it to a known value (e.g., 0.0f) to avoid undefined
startup values by either giving it an in-class default (float
_transmissionErrors = 0.0f;) or adding it to the Stats constructor initializer
list (Stats(...) : ..., _transmissionErrors(0.0f) { }). Target the
_transmissionErrors field in the Stats class/constructor when making this
change.

In `@lib/VeDirectFrameHandler/VeDirectFrameHandler.cpp`:
- Around line 336-337: The code currently treats unknown text fields as
transmission errors by calling
setErrorCounter(veStruct::Error::UNKNOWN_TEXT_DATA) alongside DTU_LOGI in
VeDirectFrameHandler.cpp; change this so unsupported/unknown fields do not
inflate the transmission error metric — either remove the setErrorCounter call
for veStruct::Error::UNKNOWN_TEXT_DATA, replace it with a non-error counter
(e.g., a warning/unsupported-field metric), or gate the increment behind a
configurable flag, and add a brief comment documenting the chosen behavior so
future readers know whether UNKNOWN_TEXT_DATA is considered a true transmission
error or just an unsupported field.
- Around line 122-134: The current logic sets _tmpFrame.transmissionErrors_Day
to the raw error sum when errorDays <= 1.0f which mislabels a count as "1/d";
change the calculation so transmissionErrors_Day is always a rate: compute
errorDays = esp_timer_get_time() / (24.0f*60*60*1000*1000) and set
_tmpFrame.transmissionErrors_Day =
_errorCounter.at(static_cast<size_t>(veStruct::Error::SUM)) / errorDays (handle
the unlikely zero case defensively), rather than skipping the division when
errorDays <= 1.0f; update any related logging/printing (printErrorCounter()
call) if you want to avoid noisy output on very small errorDays.

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/VeDirectFrameHandler/VeDirectData.cpp`:
- Around line 367-379: The code lacks a veStruct::Error value for the "Unknown
Data" bucket and so getTransmitErrorAsString cannot return a string for it; add
a new enum member (e.g., UNKNOWN_DATA) to veStruct::Error in the header and add
a corresponding entry in the frozen::map inside getTransmitErrorAsString (map
key UNKNOWN_DATA -> "Unknown Data"), then update any places that classify frames
as unknown-data to set that enum value so logs/UI can display it (refer to
getTransmitErrorAsString and the veStruct::Error enum).

In `@lib/VeDirectFrameHandler/VeDirectFrameHandler.cpp`:
- Line 398: printErrorCounter() never emits the accumulated raw total stored in
_errorSumSinceStartup, so update the function(s) that format and log error
statistics (e.g., printErrorCounter and any related summary formatter used
around the block that handles entries at lines 414-431) to append a "Total Sum"
line showing _errorSumSinceStartup; specifically, locate printErrorCounter()
(and the summary code that formats _errorCounter entries) and add a formatted
output that includes the numeric value of _errorSumSinceStartup in the same log
output so the sample "Total Sum" line can be emitted.
- Around line 175-182: Initialize the member _prevState to a known safe value in
the constructor (e.g., State::IDLE) and change the nested-hex detection in
VeDirectFrameHandler:: (the block that currently checks if ((inbyte == ':') &&
(_state != State::CHECKSUM))) to test the current state (_state ==
State::RECORD_HEX) instead of _prevState when deciding to call
setErrorCounter(veStruct::Error::NESTED_HEX); keep the existing _prevState
update logic around the RECORD_HEX transition so the previous state is still
recorded for other uses.