Add unit tests for SamlAuthenticationSuccessHandler

Author: jaburjak

Tests/Authentication/SamlAuthenticationSuccessHandlerTest.php

@@ -0,0 +1,92 @@
+<?php
+
+namespace Hslavich\OneloginSamlBundle\Tests\Authentication;
+
+use Hslavich\OneloginSamlBundle\Security\Authentication\SamlAuthenticationSuccessHandler;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Security\Http\HttpUtils;
+
+class SamlAuthenticationSuccessHandlerTest extends \PHPUnit_Framework_TestCase
+{
+    private $handler;
+
+    public function testWithAlwaysUseDefaultTargetPath()
+    {
+        $httpUtils = new HttpUtils($this->getUrlGenerator());
+        $handler = new SamlAuthenticationSuccessHandler($httpUtils, array('always_use_default_target_path' => true));
+        $defaultTargetPath = $httpUtils->generateUri($this->getRequest('/sso/login'), $this->getOption($handler, 'default_target_path', '/'));
+        $response = $handler->onAuthenticationSuccess($this->getRequest('/login', 'http://localhost/relayed'), $this->getSamlToken());
+        $this->assertTrue($response->isRedirect($defaultTargetPath), 'SamlAuthenticationSuccessHandler does not honor the always_use_default_target_path option.');
+    }
+
+    public function testRelayState()
+    {
+        $handler = new SamlAuthenticationSuccessHandler(new HttpUtils($this->getUrlGenerator()), array('always_use_default_target_path' => false));
+        $response = $handler->onAuthenticationSuccess($this->getRequest('/sso/login', 'http://localhost/relayed'), $this->getSamlToken());
+        $this->assertTrue($response->isRedirect('http://localhost/relayed'), 'SamlAuthenticationSuccessHandler is not processing the RelayState parameter properly.');
+    }
+
+    public function testWithoutRelayState()
+    {
+        $httpUtils = new HttpUtils($this->getUrlGenerator());
+        $handler = new SamlAuthenticationSuccessHandler($httpUtils, array('always_use_default_target_path' => false));
+        $defaultTargetPath = $httpUtils->generateUri($this->getRequest('/sso/login'), $this->getOption($handler, 'default_target_path', '/'));
+        $response = $handler->onAuthenticationSuccess($this->getRequest(), $this->getSamlToken());
+        $this->assertTrue($response->isRedirect($defaultTargetPath));
+    }
+
+    public function testRelayStateLoop()
+    {
+        $httpUtils = new HttpUtils($this->getUrlGenerator());
+        $handler = new SamlAuthenticationSuccessHandler($httpUtils, array('always_use_default_target_path' => false));
+        $loginPath = $httpUtils->generateUri($this->getRequest('/sso/login'), $this->getOption($handler, 'login_path', '/login'));
+        $response = $handler->onAuthenticationSuccess($this->getRequest($loginPath), $this->getSamlToken());
+        $this->assertTrue(!$response->isRedirect($loginPath), 'SamlAuthenticationSuccessHandler causes a redirect loop when RelayState points to login_path.');
+    }
+
+
+    private function getUrlGenerator()
+    {
+        $urlGenerator = $this->getMockBuilder('Symfony\Component\Routing\Generator\UrlGeneratorInterface')->getMock();
+        $urlGenerator
+            ->expects($this->any())
+            ->method('generate')
+            ->will($this->returnCallback(function($name)
+            {
+                return (string) $name;
+            }))
+        ;
+
+        return $urlGenerator;
+    }
+
+    private function getRequest($path = '/', $relayState = null)
+    {
+        $params = array();
+        if (null !== $relayState) {
+            $params['RelayState'] = $relayState;
+        }
+        return Request::create($path, 'get', $params);
+    }
+
+    private function getSamlToken()
+    {
+        $token = $this->createMock('Hslavich\OneloginSamlBundle\Security\Authentication\Token\SamlToken');
+        $token->expects($this->any())->method('getUsername')->willReturn('admin');
+        $token->method('getAttributes')->willReturn(array('foo' => 'bar'));
+
+        return $token;
+    }
+
+    private function getOption($handler, $name, $default = null)
+    {
+        $reflection = new \ReflectionObject($handler);
+        $options = $reflection->getProperty('options');
+        $options->setAccessible(true);
+        $arr = $options->getValue($handler);
+        if (!is_array($arr) || !isset($arr[$name])) {
+            return $default;
+        }
+        return $arr[$name];
+    }
+}