Skip to content

Commit 58f0f5f

Browse files
committed
make format
1 parent b49687a commit 58f0f5f

6 files changed

Lines changed: 23 additions & 15 deletions

File tree

deploy/helm/env/prod.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
image:
1111
# Bump to a newer sha-<commit> (pushed by CI on merge to main) or use latest.
12-
tag: sha-09bcf3a
12+
tag: sha-bc6c73d
1313

1414
replicas: 1
1515

@@ -112,7 +112,7 @@ taskExecution:
112112
# draft on the terminal callback. false = reviews run in-process in serge.
113113
reviewPods: true
114114
# transformers toolchain + serge (docker/Dockerfile.task-runner).
115-
image: ghcr.io/huggingface/serge-task-runner:sha-09bcf3a
115+
image: ghcr.io/huggingface/serge-task-runner:sha-bc6c73d
116116
# Wall-clock cap per task (matches the old in-process worker budget).
117117
timeout: 3600
118118
# The in-pod normalizer (make style / checkers over transformers) is
@@ -122,4 +122,4 @@ taskExecution:
122122
nodeSelector: "scheduling.cast.ai/node-template=default-by-castai"
123123
egress:
124124
# Self-built tinyproxy (docker/Dockerfile.egress-proxy).
125-
image: ghcr.io/huggingface/serge-egress:sha-09bcf3a
125+
image: ghcr.io/huggingface/serge-egress:sha-bc6c73d

reviewbot/config.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,8 +501,7 @@ def from_env(
501501
os.environ.get("TASK_K8S_NODE_SELECTOR") or ""
502502
).strip()
503503
or None,
504-
task_egress_name=(os.environ.get("TASK_EGRESS_NAME") or "").strip()
505-
or None,
504+
task_egress_name=(os.environ.get("TASK_EGRESS_NAME") or "").strip() or None,
506505
slack_bot_token=(
507506
os.environ.get("SLACK_CIFEEDBACK_BOT_TOKEN")
508507
or os.environ.get("CI_SLACK_BOT_TOKEN")

reviewbot/review_runner.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ def build_review_request(spec: RunnerSpec) -> ReviewRequest:
3535
only the fields the dataclass declares. ``inline`` (webhook follow-up
3636
context) is left at its default — UI reviews never carry it."""
3737
fields = {f.name for f in dataclasses.fields(ReviewRequest)}
38-
kwargs = {
39-
k: v for k, v in spec.request.items() if k in fields and k != "inline"
40-
}
38+
kwargs = {k: v for k, v in spec.request.items() if k in fields and k != "inline"}
4139
return ReviewRequest(**kwargs)
4240

4341

reviewbot/reviewer.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -868,7 +868,9 @@ def _run_agentic_loop(
868868
truncation_retries += 1
869869
_emit_final_salvage(emit, chat, truncation_retries)
870870
messages.append({"role": "assistant", "content": chat.content or None})
871-
messages.append({"role": "user", "content": _final_recovery_message(chat)})
871+
messages.append(
872+
{"role": "user", "content": _final_recovery_message(chat)}
873+
)
872874
force_json_only = True
873875
continue
874876
if validate is None:

tests/test_reviewer.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ def test_assistant_turn_records_content_and_tool_calls(self) -> None:
3535
content="looking at the diff",
3636
reasoning_chars=42,
3737
finish_reason="tool_calls",
38-
tool_calls=[ToolCall(id="t0", name="read_file", arguments='{"path":"a.py"}')],
38+
tool_calls=[
39+
ToolCall(id="t0", name="read_file", arguments='{"path":"a.py"}')
40+
],
3941
)
4042
self.assertEqual(len(events), 1)
4143
kind, text = events[0]
@@ -75,19 +77,25 @@ def test_none_emit_is_a_noop(self) -> None:
7577
class FinalSalvageTests(unittest.TestCase):
7678
def test_empty_content_needs_salvage(self) -> None:
7779
# The production failure: empty completion, finish_reason=None.
78-
self.assertTrue(_needs_final_salvage(ChatResult(content="", finish_reason=None)))
80+
self.assertTrue(
81+
_needs_final_salvage(ChatResult(content="", finish_reason=None))
82+
)
7983
self.assertTrue(
8084
_needs_final_salvage(ChatResult(content=" \n", finish_reason=None))
8185
)
8286

8387
def test_length_truncation_needs_salvage(self) -> None:
8488
self.assertTrue(
85-
_needs_final_salvage(ChatResult(content='{"partial', finish_reason="length"))
89+
_needs_final_salvage(
90+
ChatResult(content='{"partial', finish_reason="length")
91+
)
8692
)
8793

8894
def test_good_answer_does_not_need_salvage(self) -> None:
8995
self.assertFalse(
90-
_needs_final_salvage(ChatResult(content='{"ok": true}', finish_reason="stop"))
96+
_needs_final_salvage(
97+
ChatResult(content='{"ok": true}', finish_reason="stop")
98+
)
9199
)
92100

93101
def test_recovery_message_varies_by_cause(self) -> None:

tests/test_webapp_tasks.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -800,8 +800,9 @@ def test_ingest_review_reconstructs_draft(self):
800800
)
801801
from reviewbot.store import encode_draft
802802

803-
with patch.object(webapp, "_persist_terminal"), patch.object(
804-
webapp, "_notify_task_finished"
803+
with (
804+
patch.object(webapp, "_persist_terminal"),
805+
patch.object(webapp, "_notify_task_finished"),
805806
):
806807
client = TestClient(webapp.app)
807808
r = client.post(

0 commit comments

Comments
 (0)