Skip to content

Commit 795d693

Browse files
committed
tweak arhs
1 parent 16aebfb commit 795d693

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

.github/workflows/ai-review.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,19 @@ jobs:
5555
- name: Connect to Tailscale
5656
uses: tailscale/github-action@v4
5757
with:
58-
# Workload-identity federation: the action exchanges a GitHub
59-
# OIDC token (audience-scoped) for tailnet access, so no
60-
# long-lived auth key is stored. The runner joins as an
61-
# ephemeral, tag:ci-tagged node.
58+
# OAuth client auth: the secret mints an ephemeral, pre-authorized
59+
# tag:ci node. The action always passes --accept-routes itself, so
60+
# the tailnet's advertised subnet route to the 10.90.0.0 network
61+
# (where serge.huggingface.tech / 10.90.52.50 lives) is installed.
6262
oauth-client-id: ${{ secrets.TS_OAUTH_CLIENT_ID_AI_REVIEW }}
6363
oauth-secret: ${{ secrets.TS_AUDIENCE_AI_REVIEW }}
6464
tags: tag:ci
65-
args: --accept-routes --accept-dns=false
65+
# --accept-dns=false: keep the runner's own resolver, which already
66+
# resolves serge.huggingface.tech -> 10.90.52.50. Letting MagicDNS
67+
# accept tailnet DNS hijacks lookups to an internal nameserver that
68+
# hangs (curl: (28) Resolving timed out). Do NOT add --accept-routes
69+
# here; the action injects it and a duplicate flag errors.
70+
args: --accept-dns=false
6671

6772
- name: Relay event to the Serge GitHub App
6873
env:

0 commit comments

Comments
 (0)