enforce comment when used as direct PR trigger

Author: tarekziade

reviewbot/action_runner.py

@@ -133,7 +133,7 @@ def main() -> int:
         if req.inline is not None:
             run_followup(cfg, gh, req)
         else:
-            run_review(cfg, gh, req)
+            run_review(cfg, gh, req, force_comment_event=True)
     except LLMResponseError as exc:
         message = _format_llm_response_error(exc)
         log.warning("review failed: %s", message)

reviewbot/app.py

@@ -51,7 +51,7 @@ def _review_worker(installation_id: int, req: ReviewRequest) -> None:
         if req.inline is not None:
             run_followup(cfg, gh, req)
         else:
-            run_review(cfg, gh, req)
+            run_review(cfg, gh, req, force_comment_event=True)
     except Exception:
         log.exception(
             "review worker crashed for %s/%s#%d", req.owner, req.repo, req.number

reviewbot/reviewer.py

@@ -1394,7 +1394,13 @@ def publish_review(
     )
 
 
-def run_review(cfg: Config, gh: GitHubClient, req: ReviewRequest) -> None:
+def run_review(
+    cfg: Config,
+    gh: GitHubClient,
+    req: ReviewRequest,
+    *,
+    force_comment_event: bool = False,
+) -> None:
     """Webhook + Action entry point. Unchanged behavior: prepares the
     review, then immediately publishes it. Renders a fallback issue
     comment if the LLM output is unparseable."""
@@ -1410,7 +1416,8 @@ def run_review(cfg: Config, gh: GitHubClient, req: ReviewRequest) -> None:
         return
     if draft is None:
         return
-    publish_review(cfg, gh, draft)
+    edits = ReviewEdits(event="COMMENT") if force_comment_event else None
+    publish_review(cfg, gh, draft, edits=edits)
 
 
 _FOLLOWUP_FORCE_FINAL_MESSAGE = (

tests/test_action_runner.py

@@ -43,6 +43,26 @@ def _inline_comment_payload(*, fork: bool = False) -> dict:
     return payload
 
 
+def _issue_comment_payload() -> dict:
+    return {
+        "action": "created",
+        "comment": {
+            "id": 123,
+            "body": "@askserge please review",
+            "author_association": "MEMBER",
+            "user": {"login": "reviewer"},
+        },
+        "issue": {
+            "number": 13827,
+            "state": "open",
+            "pull_request": {
+                "url": "https://api.github.com/repos/huggingface/diffusers/pulls/13827"
+            },
+        },
+        "repository": {"full_name": "huggingface/diffusers"},
+    }
+
+
 class ActionRunnerTests(unittest.TestCase):
     def test_empty_llm_api_key_fails_before_review(self) -> None:
         event_path = _write_event(_inline_comment_payload())
@@ -121,6 +141,26 @@ def test_llm_api_key_is_stripped_before_review(self) -> None:
         cfg = run_followup.call_args.args[0]
         self.assertEqual(cfg.llm_api_key, "token-with-newline")
 
+    def test_direct_pr_review_forces_comment_event(self) -> None:
+        event_path = _write_event(_issue_comment_payload())
+        self.addCleanup(os.remove, event_path)
+        env = {
+            "GITHUB_EVENT_NAME": "issue_comment",
+            "GITHUB_EVENT_PATH": event_path,
+            "GITHUB_TOKEN": "github-token",
+            "LLM_API_KEY": "token",
+        }
+
+        with (
+            patch.dict(os.environ, env, clear=True),
+            patch("reviewbot.action_runner.run_review") as run_review,
+            patch("reviewbot.action_runner.GitHubClient"),
+        ):
+            code = action_runner.main()
+
+        self.assertEqual(code, 0)
+        self.assertTrue(run_review.call_args.kwargs["force_comment_event"])
+
     def test_llm_response_error_is_logged_without_traceback(self) -> None:
         event_path = _write_event(_inline_comment_payload())
         self.addCleanup(os.remove, event_path)

tests/test_publish_review.py

@@ -3,14 +3,16 @@
 and edit-application rules."""
 
 import unittest
-from unittest.mock import MagicMock
+from unittest.mock import MagicMock, patch
 
 from reviewbot.config import Config
 from reviewbot.reviewer import (
     DraftComment,
     ReviewDraft,
     ReviewEdits,
+    ReviewRequest,
     publish_review,
+    run_review,
 )
 
 
@@ -174,6 +176,24 @@ def test_empty_summary_renders_fallback(self) -> None:
         body = gh.create_review.call_args.kwargs["body"]
         self.assertIn("(no overall summary provided)", body)
 
+    def test_run_review_can_force_comment_event_for_direct_publish(self) -> None:
+        cfg = _make_cfg()
+        draft = _make_draft(event="REQUEST_CHANGES")
+        gh = MagicMock()
+        req = ReviewRequest(
+            owner="acme",
+            repo="widgets",
+            number=42,
+            trigger_comment_id=123,
+            trigger_comment_body="@askserge please review",
+            commenter="reviewer",
+        )
+
+        with patch("reviewbot.reviewer.prepare_review", return_value=draft):
+            run_review(cfg, gh, req, force_comment_event=True)
+
+        self.assertEqual(gh.create_review.call_args.kwargs["event"], "COMMENT")
+
 
 if __name__ == "__main__":
     unittest.main()