Skip to content

Commit b915dd5

Browse files
aaahuhonghuhong-web
authored andcommitted
fix(parseutil): replace os.CreateTemp with t.TempDir for auto-cleanup
1 parent 66b02cb commit b915dd5

1 file changed

Lines changed: 27 additions & 35 deletions

File tree

internal/utils/parseutil/parseutils_test.go

Lines changed: 27 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,33 @@ package parseutil
1717
import (
1818
"math"
1919
"os"
20+
"path/filepath"
2021
"strconv"
2122
"testing"
2223
)
2324

25+
func createTempFile(t *testing.T, content string) string {
26+
t.Helper()
27+
dir := t.TempDir()
28+
path := filepath.Join(dir, "tmp-file")
29+
if err := os.WriteFile(path, []byte(content), 0o600); err != nil {
30+
t.Fatalf("createTempFile: %v", err)
31+
}
32+
return path
33+
}
34+
35+
func mapsEqual(a, b map[string]uint64) bool {
36+
if len(a) != len(b) {
37+
return false
38+
}
39+
for k, v := range a {
40+
if b[k] != v {
41+
return false
42+
}
43+
}
44+
return true
45+
}
46+
2447
func TestReadUint(t *testing.T) {
2548
tests := []struct {
2649
name string
@@ -38,8 +61,7 @@ func TestReadUint(t *testing.T) {
3861
path := createTempFile(t, tt.content)
3962
got, err := ReadUint(path)
4063
if (err != nil) != tt.wantErr {
41-
t.Errorf("ReadUint() error = %v, wantErr %v", err, tt.wantErr)
42-
return
64+
t.Fatalf("ReadUint() error = %v, wantErr %v", err, tt.wantErr)
4365
}
4466
if got != tt.want {
4567
t.Errorf("ReadUint() = %v, want %v", got, tt.want)
@@ -72,8 +94,7 @@ func TestReadInt(t *testing.T) {
7294
path := createTempFile(t, tt.content)
7395
got, err := ReadInt(path)
7496
if (err != nil) != tt.wantErr {
75-
t.Errorf("ReadInt() error = %v, wantErr %v", err, tt.wantErr)
76-
return
97+
t.Fatalf("ReadInt() error = %v, wantErr %v", err, tt.wantErr)
7798
}
7899
if got != tt.want {
79100
t.Errorf("ReadInt() = %v, want %v", got, tt.want)
@@ -125,8 +146,7 @@ func TestRawKV(t *testing.T) {
125146
path := createTempFile(t, tt.content)
126147
got, err := RawKV(path)
127148
if (err != nil) != tt.wantErr {
128-
t.Errorf("RawKV() error = %v, wantErr %v", err, tt.wantErr)
129-
return
149+
t.Fatalf("RawKV() error = %v, wantErr %v", err, tt.wantErr)
130150
}
131151
if !mapsEqual(got, tt.want) {
132152
t.Errorf("RawKV() = %v, want %v", got, tt.want)
@@ -183,8 +203,7 @@ func TestKV(t *testing.T) {
183203
path := createTempFile(t, tt.content)
184204
gotKey, gotVal, err := KV(path)
185205
if (err != nil) != tt.wantErr {
186-
t.Errorf("KV() error = %v, wantErr %v", err, tt.wantErr)
187-
return
206+
t.Fatalf("KV() error = %v, wantErr %v", err, tt.wantErr)
188207
}
189208
if gotKey != tt.wantKey || gotVal != tt.wantVal {
190209
t.Errorf("KV() = %v, %v, want %v, %v", gotKey, gotVal, tt.wantKey, tt.wantVal)
@@ -198,30 +217,3 @@ func TestKV(t *testing.T) {
198217
}
199218
})
200219
}
201-
202-
// Helper to create temp file with content
203-
func createTempFile(t *testing.T, content string) string {
204-
t.Helper()
205-
file, err := os.CreateTemp("", "parseutil_test_*")
206-
if err != nil {
207-
t.Errorf("create temp directory: %v", err)
208-
}
209-
defer file.Close()
210-
if _, err := file.WriteString(content); err != nil {
211-
t.Errorf("write file: %v", err)
212-
}
213-
return file.Name()
214-
}
215-
216-
// Helper to compare maps
217-
func mapsEqual(a, b map[string]uint64) bool {
218-
if len(a) != len(b) {
219-
return false
220-
}
221-
for k, v := range a {
222-
if b[k] != v {
223-
return false
224-
}
225-
}
226-
return true
227-
}

0 commit comments

Comments
 (0)