Current list of bugs preventing adoption of latest version by PHPStan

[ondrejmirtes]

Bug report

Question	Answer
PHP-Scoper version	The one in 4.6.5@0964604 2025-03-02 18:34:04 UTC
PHP version	8.2.28
Platform with version	ubuntu-latest

After a long time I tried the latest Box version in PHPStan again. The progress is great! A lot of issues went away and the scoped code is nicer. There are some new bugs that appeared:

1. PHP-Scoper should understand that some strings that contain a valid internal PHP class name should not be prefixed. Some examples:

- 'Dom\NamedNodeMap'
+ '_PHPStan_checksum\Dom\NamedNodeMap'

- 'BcMath\Number'
+ '_PHPStan_checksum\BcMath\Number'

- 'Ds\Map'
+ _PHPStan_checksum\Ds\Map

2. For some reason tests of some packages are suddenly included in the PHAR file. Namely:

• https://github.com/hoaproject/Compiler/tree/master/Test (and other Hoa packages)
• https://github.com/symfony/service-contracts/tree/main/Test

Additionally, there's a specific bugfix in nikic/PHP-Parser 5.5.0 (for code to be usable on PHP 7.4, attribute and parameter cannot be on the same line). It'd be great if you could bump this in PHP-Scoper + Box and publish a new box.phar 😊

Thank you.

[ondrejmirtes]

If you want to see the diff between the last working PHPStan version and the new one on the latest Box, here's the diff: ondrejmirtes/phar-git@d947786

Here's the PR phpstan/phpstan-src#2955.

[ondrejmirtes]

Would be great if it didn't touch array keys in this file at all: https://github.com/ondrejmirtes/phar-git/blob/main/vendor/jetbrains/phpstorm-stubs/PhpStormStubsMap.php (it adds _PHPStan_checksum prefix everywhere).

[theofidry]

PHP-Scoper should understand that some strings that contain a valid internal PHP class name should not be prefixed. Some examples:

That should actually already be the case, what factors in is what kind of string it is. GitHub crashed when trying to look for those strings in the diff so I'll try to download it separately to check.

For some reason tests of some packages are suddenly included in the PHAR file.

I can double check, but IIRC there was some annoyances with the pattern matching with the Symfony Finder. There is some tests though so will be able to have a look at least.

Additionally, there's a specific bugfix in nikic/PHP-Parser 5.5.0

Will do ASAP.

Would be great if it didn't touch array keys in this file at all: https://github.com/ondrejmirtes/phar-git/blob/main/vendor/jetbrains/phpstorm-stubs/PhpStormStubsMap.php (it adds _PHPStan_checksum prefix everywhere).

Aren't you excluding those files from the scoping? IIRC in PHP-Scoper I do so with https://github.com/humbug/php-scoper/blob/main/scoper.inc.php#L15-L16

Otherwise I'm not sure to see how PHP-Scoper could safely natively ignore those

[ondrejmirtes]

I'm not excluding that file, I need the class to have a prefixed namespace.

PHP-Scoper should see precisely that these classes are in phpstorm-stubs, and should not prefix their names in the map 😊

[ondrejmirtes]

Made the diff a bit more manageable: ondrejmirtes/phar-git@1f03324

[ondrejmirtes]

This is a bit more nicer: ondrejmirtes/phar-git@640b530

[ondrejmirtes]

I just realized there's a more useful way of checking out the differences. Just by listing the occurrences of the prefix. Here's a diff between 2.1.x and the updating PR: https://gist.github.com/ondrejmirtes/e28e35cb7d5597ed2c605d2bbfc56e7b/revisions

Some of those changes are wanted, some not.

[ondrejmirtes]

The changes in vendor/composer/autoload_* are just noise, before the arrays were collapsed on a single line, now it's multiple lines, but the contents did not change.

[ondrejmirtes]

Alright, I've automatized this and now a really readable and useful diff is printed as part of GitHub Actions in phpstan-src.

It now shows all the bugs I've encountered here: https://github.com/phpstan/phpstan-src/actions/runs/15445860452/job/43475350514

I can patch around them but I'd prefer if they were fixed in php-scoper 😊

It also made me realize that the names in jetbrains/phpstorm-stubs map were prefixed already but I removed the patch by mistake.