Follow-up: deferred review findings from PR #817

[philcunliffe]

Triage of PR #817 (integration/proxy-mode-default-attach, head ef99b06a) after its two review rounds found no blocking residue. Every finding below was re-verified against the tree at head, not taken from the review records. The design's central claim holds: LLP 0242 is implemented on master exactly as LLP 0251 and 0249 describe (manifest gateway_proxy_mode at hypaware-core/plugins-workspace/claude/hypaware.plugin.json:45, the composePickerConfig fold at src/core/cli/walkthrough.js:994/:1035, maybeOfferProxyModeMigration at src/core/commands/clients.js:821 with the non-interactive gate at :886, enableGatewayProxyMode at src/core/config/gateway_proxy_enable.js:69 with both refusals at :154), the gate suite is 45/45 at head, and the new --json pin goes cleanly red when either the :886 gate or the json propagation at :457 is perturbed. These deferred items remain:

1. PR #822 collision: LLP 0244 merge conflict plus LLP 0251 going stale (medium, merge-time action)

Open PR #822 (fix/issue-819) edits the same llp/0244-attach-migrates-to-proxy-mode.decision.md metadata block this PR touches. Trial-merging origin/fix/issue-819 into ef99b06a reproduces:

CONFLICT (content): Merge conflict in llp/0244-attach-migrates-to-proxy-mode.decision.md

(#817 appends , LLP 0251 to the Related: continuation line; #822 inserts an **Extended-by:** LLP 0259 block right after it. Keep both; nothing settled is touched. test/core/attach-proxy-migration.test.js auto-merges cleanly.)

Separately, once #822's LLP 0259 lands, two sentences in llp/0251-proxy-mode-default-attach.design.md section 3 become inaccurate: line 97 ("keyed on the config, not the CA") and lines 132-133 ("Once the key is set the offer never appears again"). LLP 0259 settles the opposite for the key-on / CA-missing case (its forward-ref on 0244: the gate reads the CA as well as the config, so proxy_mode: true with no CA reaches a repair). Today, with #822 unmerged, LLP 0251's prose is accurate against the tree, and pre-emptively citing LLP 0259 from this branch would mint a dangling citation, so this is correctly not fixed in #817.

Action for whichever of #817 / #822 merges second: resolve the 0244 metadata conflict by keeping both lines, and append **Extended-by:** LLP 0259 (#migration: the offer gate also reads the CA; key-on with no CA reaches a repair instead of returning) to LLP 0251's metadata.

No behavioural conflict: on the trial-merged tree the proxy suites run green and #822 preserves the parsed.json short-circuit verbatim.

2. Merge-order constraint: #815 first (informational, still true)

llp/0251 cites LLP 0245 (section 0 and section 3) and declares Depends-on: proxy-mode-capture, but llp/0245-* exists only on origin/integration/proxy-mode-capture (PR #815, still open; no other remote branch carries it, verified by sweep). Merging #817 first lands a design of record citing a document absent from the tree. The PR body's merge-notes block records this; nothing enforces it. Honor the ordering at merge time.

3. LLP 0249 line citations are commit-relative and have drifted at head (low)

llp/0249-proxy-mode-default-attach.plan.md cites walkthrough.js lines 973/1014/1276/1537, correct at its stated anchor 04330abb but a uniform +21 off at ef99b06a (real positions 994/1035/1297/1558). The doc names its anchor commit, so the citations are not wrong, merely stale when read against head. Same section's "32/32 across the five named test files" is 34/34 since T1 landed (45/45 with attach-enablement-state.test.js). LLP 0249 is Active; if anyone corrects it, do so as an editorial note rather than rewriting the audit record.

---

Backlink: PR #817. Review records: round 1 3efab8c2 and round 2 ef99b06a comments on that PR.

[philcunliffe]

Picked this up as a neutral:fix follow-up and tried to work all three findings from a clean worktree at origin/master (a14246d9, npm install, suite green). None of them can be acted on from master today. This is a sequencing block, not a failed attempt: nothing was tried and abandoned, there is simply no code or document on master for any of the three to touch.

What each finding needs, and where it lives:

1. PR detach --purge then attach no longer downgrades claude to base URL in silence #822 collision (LLP 0244 metadata conflict, LLP 0251 going stale). By its own description this is a merge-time action: it fires when the second of Proxy mode by default: design of record for LLP 0242, plus the missing --json non-interactive pin #817 / detach --purge then attach no longer downgrades claude to base URL in silence #822 merges. llp/0251-proxy-mode-default-attach.design.md does not exist on master (it arrives with Proxy mode by default: design of record for LLP 0242, plus the missing --json non-interactive pin #817, integration/proxy-mode-default-attach), and the Extended-by: LLP 0259 block it would gain arrives with detach --purge then attach no longer downgrades claude to base URL in silence #822 (fix/issue-819). Neither side of the conflict is present here, so there is no conflict to pre-resolve.

2. Merge-order constraint, Proxy-mode capture: design of record for RFC 0231, plus the missing claude_proxy_capture acceptance procedure #815 first. Informational by construction. llp/0245-proxy-mode-capture.design.md exists only on origin/integration/proxy-mode-capture (PR Proxy-mode capture: design of record for RFC 0231, plus the missing claude_proxy_capture acceptance procedure #815), and llp/0249/llp/0251 (which cite it) only on Proxy mode by default: design of record for LLP 0242, plus the missing --json non-interactive pin #817. ls llp/ on master confirms 0245, 0248, 0249, 0251 and 0259 are all absent. Nothing on master enforces or records an ordering between two unmerged branches.

3. LLP 0249 line citations drifted, and its 32/32 count is stale. llp/0249-proxy-mode-default-attach.plan.md is on PR Proxy mode by default: design of record for LLP 0242, plus the missing --json non-interactive pin #817's branch only. Editing a document that does not exist here is not possible, and the finding itself notes 0249 is Active and names its own anchor commit, so the citations are stale-when-read-against-head rather than wrong.

No neutral:fix PR was opened, because a PR touching nothing would be worse than none.

Concrete action for a human: merge PR #817 (and #822, whose merge is what makes items 1 and 3 actionable), resolving the llp/0244 metadata conflict by keeping both lines as item 1 describes. Once both are on master, items 1 and 3 become ordinary in-tree edits and this issue can be worked in a single pass.

Reply on this issue; neutral monitors this thread and will re-engage with your guidance on its next tick.

[philcunliffe]

Closing as obsolete. These notes concern old proxy-mode merge ordering and stale line references; that proxy mode was subsequently removed, so the reviewed surface no longer exists.