[Tests] Fixed precision in ParameterProviderTest::testGetViewParameters (#560)

alongosz · web-flow · commit 01d5a98ca800 · 2025-05-30T17:11:33.000+02:00
PHP 8.1+ added more precision when computing date time difference in days
diff --git a/tests/lib/MVC/Symfony/FieldType/User/ParameterProviderTest.php b/tests/lib/MVC/Symfony/FieldType/User/ParameterProviderTest.php
@@ -44,12 +44,8 @@ protected function setUp(): void
         $this->parameterProvider = new ParameterProvider($this->userService);
     }
 
-    /**
-     * @requires PHP < 8.1
-     */
     public function testGetViewParameters(): void
     {
-        $passwordExpiresIn = 14;
         $passwordExpiresAt = (new DateTimeImmutable())->add(new DateInterval('P14D'));
 
         $this->userService
@@ -63,7 +59,9 @@ public function testGetViewParameters(): void
 
         self::assertFalse($parameters['is_password_expired']);
         self::assertEquals($passwordExpiresAt, $parameters['password_expires_at']);
-        self::assertEquals($passwordExpiresIn, $parameters['password_expires_in']->days);
+        // since PHP 8.1 computing date time includes microseconds, so the difference is not deterministic
+        self::assertGreaterThanOrEqual(13, $parameters['password_expires_in']->days);
+        self::assertLessThanOrEqual(14, $parameters['password_expires_in']->days);
     }
 
     public function testGetViewParametersWhenPasswordExpirationDateIsNull(): void

Original file line number	Diff line number	Diff line change
`@@ -44,12 +44,8 @@ protected function setUp(): void`
`44`	`44`	`$this->parameterProvider = new ParameterProvider($this->userService);`
`45`	`45`	`}`
`46`	`46`
`47`		`- /**`
`48`		`- * @requires PHP < 8.1`
`49`		`- */`
`50`	`47`	`public function testGetViewParameters(): void`
`51`	`48`	`{`
`52`		`- $passwordExpiresIn = 14;`
`53`	`49`	`$passwordExpiresAt = (new DateTimeImmutable())->add(new DateInterval('P14D'));`
`54`	`50`
`55`	`51`	`$this->userService`
`@@ -63,7 +59,9 @@ public function testGetViewParameters(): void`
`63`	`59`
`64`	`60`	`self::assertFalse($parameters['is_password_expired']);`
`65`	`61`	`self::assertEquals($passwordExpiresAt, $parameters['password_expires_at']);`
`66`		`- self::assertEquals($passwordExpiresIn, $parameters['password_expires_in']->days);`
	`62`	`+ // since PHP 8.1 computing date time includes microseconds, so the difference is not deterministic`
	`63`	`+ self::assertGreaterThanOrEqual(13, $parameters['password_expires_in']->days);`
	`64`	`+ self::assertLessThanOrEqual(14, $parameters['password_expires_in']->days);`
`67`	`65`	`}`
`68`	`66`
`69`	`67`	`public function testGetViewParametersWhenPasswordExpirationDateIsNull(): void`