Refactored SerializerFactory to simplify create method by removing redundant Traversable checks and improving property encapsulation.

Author: MateuszKolankowski

src/bundle/Core/Serializer/SerializerFactory.php

@@ -9,7 +9,6 @@
 namespace Ibexa\Bundle\Core\Serializer;
 
 use Symfony\Component\Serializer\Serializer;
-use Traversable;
 
 final readonly class SerializerFactory
 {
@@ -18,21 +17,15 @@
      * @param iterable<\Symfony\Component\Serializer\Encoder\EncoderInterface|\Symfony\Component\Serializer\Encoder\DecoderInterface> $encoders
      */
     public function __construct(
-        public iterable $normalizers,
-        public iterable $encoders
-    ) {}
+        private iterable $normalizers,
+        private iterable $encoders
+    ) {
+    }
 
     public function create(): Serializer
     {
-        $normalizers = $this->normalizers;
-        if ($normalizers instanceof Traversable) {
-            $normalizers = iterator_to_array($normalizers);
-        }
-
-        $encoders = $this->encoders;
-        if ($encoders instanceof Traversable) {
-            $encoders = iterator_to_array($encoders);
-        }
+        $normalizers = iterator_to_array($this->normalizers);
+        $encoders = iterator_to_array($this->encoders);
 
         return new Serializer($normalizers, $encoders);
     }