IBX-9727: Add missing type hints to PAPI events (#557)

* IBX-9727: Changed Ibexa\Contracts\Core\Repository\ContentService::deleteContent return type to array
* IBX-9727: Changed \Ibexa\Contracts\Core\Repository\UserService::{deleteUser, deleteUserGroup} return type to array
* IBX-9727: Added missing type hints to events

Author: adamwojs

phpstan-baseline.neon

@@ -223,7 +223,7 @@ public function updateContentMetadata(ContentInfo $contentInfo, ContentMetadataU
      *
      * @return array<int, int> Affected Location IDs (List of Location IDs of the Content that was deleted).
      */
-    public function deleteContent(ContentInfo $contentInfo): iterable;
+    public function deleteContent(ContentInfo $contentInfo): array;
 
     /**
      * Creates a draft from a published or archived version.

src/contracts/Repository/ContentService.php

@@ -129,7 +129,7 @@ public function updateContentMetadata(
         return $this->innerService->updateContentMetadata($contentInfo, $contentMetadataUpdateStruct);
     }
 
-    public function deleteContent(ContentInfo $contentInfo): iterable
+    public function deleteContent(ContentInfo $contentInfo): array
     {
         return $this->innerService->deleteContent($contentInfo);
     }

src/contracts/Repository/Decorator/ContentServiceDecorator.php

@@ -65,7 +65,7 @@ public function loadSubUserGroups(
         return $this->innerService->loadSubUserGroups($userGroup, $offset, $limit, $prioritizedLanguages);
     }
 
-    public function deleteUserGroup(UserGroup $userGroup): iterable
+    public function deleteUserGroup(UserGroup $userGroup): array
     {
         return $this->innerService->deleteUserGroup($userGroup);
     }
@@ -134,7 +134,7 @@ public function loadUserByToken(
         return $this->innerService->loadUserByToken($hash, $prioritizedLanguages);
     }
 
-    public function deleteUser(User $user): iterable
+    public function deleteUser(User $user): array
     {
         return $this->innerService->deleteUser($user);
     }

src/contracts/Repository/Decorator/UserServiceDecorator.php

@@ -13,8 +13,7 @@
 
 final class BeforeCreateBookmarkEvent extends BeforeEvent
 {
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Location */
-    private $location;
+    private Location $location;
 
     public function __construct(Location $location)
     {

src/contracts/Repository/Events/Bookmark/BeforeCreateBookmarkEvent.php

@@ -13,8 +13,7 @@
 
 final class BeforeDeleteBookmarkEvent extends BeforeEvent
 {
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Location */
-    private $location;
+    private Location $location;
 
     public function __construct(Location $location)
     {

src/contracts/Repository/Events/Bookmark/BeforeDeleteBookmarkEvent.php

@@ -13,8 +13,7 @@
 
 final class CreateBookmarkEvent extends AfterEvent
 {
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Location */
-    private $location;
+    private Location $location;
 
     public function __construct(Location $location)
     {

src/contracts/Repository/Events/Bookmark/CreateBookmarkEvent.php

@@ -13,8 +13,7 @@
 
 final class DeleteBookmarkEvent extends AfterEvent
 {
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Location */
-    private $location;
+    private Location $location;
 
     public function __construct(Location $location)
     {

src/contracts/Repository/Events/Bookmark/DeleteBookmarkEvent.php

@@ -15,14 +15,11 @@
 
 final class AddRelationEvent extends AfterEvent
 {
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Relation */
-    private $relation;
+    private Relation $relation;
 
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo */
-    private $sourceVersion;
+    private VersionInfo $sourceVersion;
 
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo */
-    private $destinationContent;
+    private ContentInfo $destinationContent;
 
     public function __construct(
         Relation $relation,

src/contracts/Repository/Events/Content/AddRelationEvent.php

@@ -16,14 +16,11 @@
 
 final class BeforeAddRelationEvent extends BeforeEvent
 {
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo */
-    private $sourceVersion;
+    private VersionInfo $sourceVersion;
 
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo */
-    private $destinationContent;
+    private ContentInfo $destinationContent;
 
-    /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Relation|null */
-    private $relation;
+    private ?Relation $relation = null;
 
     public function __construct(VersionInfo $sourceVersion, ContentInfo $destinationContent)
     {