Update method signatures and annotations

Author: MateuszKolankowski

src/bundle/Core/Features/Context/FieldTypeContext.php

@@ -200,14 +200,11 @@ public function getFieldContentState()
         return $this->fieldConstructionObject['objectState'];
     }
 
-    /**
-     * Creates and publishes the content with a given field and
-     * based on the internal ContentType.
-     *
-     * @param string|null $field
-     * @param mixed $value
-     */
-    private function createAndPublishContent($field, $value)
+/**
+ * Creates and publishes the content with a given field and
+ * based on the internal ContentType.
+ */
+private function createAndPublishContent(?string $field, mixed $value): void
     {
         $languageCode = self::DEFAULT_LANGUAGE;
 

src/bundle/IO/Resources/config/io.yml

@@ -45,8 +45,8 @@ services:
         arguments:
             $imageFileList: '@Ibexa\Bundle\Core\Imagine\VariationPurger\LegacyStorageImageFileList'
             $variationPathGenerator: '@ibexa.image_alias.variation_path_generator'
-            $filterConfiguration: "@liip_imagine.filter.configuration"
-            $imagesDir: "%ibexa.site_access.config.default.image.published_images_dir%"
+            $filterConfiguration: '@liip_imagine.filter.configuration'
+            $imagesDir: '%ibexa.site_access.config.default.image.published_images_dir%'
         tags:
             - { name: "ibexa.io.migration.file_lister", identifier: "image_file" }
         lazy: true

src/lib/MVC/Symfony/Security/HttpUtils.php

@@ -13,12 +13,8 @@
 
 class HttpUtils extends BaseHttpUtils implements SiteAccessAware
 {
-    /** @var \Ibexa\Core\MVC\Symfony\SiteAccess */
-    private $siteAccess;
+    private ?SiteAccess $siteAccess;
 
-    /**
-     * @param \Ibexa\Core\MVC\Symfony\SiteAccess|null $siteAccess
-     */
     public function setSiteAccess(?SiteAccess $siteAccess = null)
     {
         $this->siteAccess = $siteAccess;
@@ -27,7 +23,7 @@ public function setSiteAccess(?SiteAccess $siteAccess = null)
     private function analyzeLink($path)
     {
         if (
-            $this->siteAccess === null
+            !isset($this->siteAccess)
             || $path[0] !== '/'
             || !($this->siteAccess->matcher instanceof SiteAccess\URILexer)
         ) {

src/lib/Repository/ContentService.php

@@ -1070,22 +1070,6 @@ public function deleteContent(ContentInfo $contentInfo): iterable
         return $affectedLocations;
     }
 
-    /**
-     * Creates a draft from a published or archived version.
-     *
-     * If no version is given, the current published version is used.
-     *
-     * @param \Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo $contentInfo
-     * @param \Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo|null $versionInfo
-     * @param \Ibexa\Contracts\Core\Repository\Values\User\User|null $creator if set given user is used to create the draft - otherwise the current-user is used
-     * @param \Ibexa\Contracts\Core\Repository\Values\Content\Language|null $language if not set the draft is created with the initialLanguage code of the source version or if not present with the main language.
-     *
-     * @return \Ibexa\Contracts\Core\Repository\Values\Content\Content - the newly created content draft
-     *
-     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\ForbiddenException
-     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException if the current-user is not allowed to create the draft
-     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException if the current-user is not allowed to create the draft
-     */
     public function createContentDraft(
         ContentInfo $contentInfo,
         ?APIVersionInfo $versionInfo = null,

tests/integration/Core/Repository/URLAliasServiceTest.php

@@ -339,8 +339,6 @@ public function testCreateGlobalUrlAlias()
     }
 
     /**
-     * @param \Ibexa\Contracts\Core\Repository\Values\Content\URLAlias $createdUrlAlias
-     *
      * @depends testCreateGlobalUrlAlias
      */
     public function testCreateGlobalUrlAliasPropertyValues(URLAlias $createdUrlAlias)
@@ -391,8 +389,6 @@ public function testCreateGlobalUrlAliasWithForward()
     }
 
     /**
-     * @param \Ibexa\Contracts\Core\Repository\Values\Content\URLAlias $createdUrlAlias
-     *
      * @depends testCreateGlobalUrlAliasWithForward
      */
     public function testCreateGlobalUrlAliasWithForwardPropertyValues(URLAlias $createdUrlAlias)
@@ -444,8 +440,6 @@ public function testCreateGlobalUrlAliasWithAlwaysAvailable()
     }
 
     /**
-     * @param \Ibexa\Contracts\Core\Repository\Values\Content\URLAlias $createdUrlAlias
-     *
      * @depends testCreateGlobalUrlAliasWithAlwaysAvailable
      */
     public function testCreateGlobalUrlAliasWithAlwaysAvailablePropertyValues(URLAlias $createdUrlAlias)
@@ -538,7 +532,7 @@ public function testCreateGlobalUrlAliasForLocationVariation()
     }
 
     /**
-     * @param array<mixed> $testData
+     * @param array{\Ibexa\Contracts\Core\Repository\Values\Content\URLAlias, int} $testData
      *
      * @depends testCreateGlobalUrlAliasForLocation
      */
@@ -564,7 +558,7 @@ public function testCreateGlobalUrlAliasForLocationPropertyValues($testData)
     }
 
     /**
-     * @param array<mixed> $testData
+     * @param array{\Ibexa\Contracts\Core\Repository\Values\Content\URLAlias, int} $testData
      *
      * @depends testCreateGlobalUrlAliasForLocationVariation
      */