Write tests for IBX-11610: Images with width= or height= in xml definition will cause crash

Author: vidarl

tests/bundle/Core/Imagine/AliasGeneratorTest.php

@@ -247,6 +247,57 @@ public function testGetVariationOriginal(): void
         );
     }
 
+    public function testGetVariationOriginalWithNullWidthAndHeight(): void
+    {
+        $originalPath = 'foo/bar/image.jpg';
+        $variationName = 'original';
+        $imageId = '123-45';
+        $imageValue = new ImageValue(
+            [
+                'id' => $originalPath,
+                'imageId' => $imageId,
+                'width' => null,
+                'height' => null,
+                'fileSize' => 1024,
+                'mime' => 'image/jpeg',
+            ]
+        );
+        $field = new Field([
+            'value' => $imageValue,
+            'fieldDefIdentifier' => 'image_field',
+        ]);
+        $expectedUrl = 'http://localhost/foo/bar/image.jpg';
+
+        $this->ioResolver
+            ->expects(self::once())
+            ->method('resolve')
+            ->with($originalPath, $variationName)
+            ->will(self::returnValue($expectedUrl));
+
+        $expected = new ImageVariation(
+            [
+                'name' => $variationName,
+                'fileName' => 'image.jpg',
+                'dirPath' => 'http://localhost/foo/bar',
+                'uri' => $expectedUrl,
+                'imageId' => $imageId,
+                'height' => null,
+                'width' => null,
+                'fileSize' => 1024,
+                'mimeType' => 'image/jpeg',
+            ]
+        );
+
+        self::assertEquals(
+            $expected,
+            $this->aliasGenerator->getVariation(
+                $field,
+                new VersionInfo(),
+                $variationName
+            )
+        );
+    }
+
     /**
      * Test obtaining Image Variation that hasn't been stored yet and has multiple references.
      *

tests/lib/FieldType/ImageTest.php

@@ -8,6 +8,7 @@
 namespace Ibexa\Tests\Core\FieldType;
 
 use Ibexa\Contracts\Core\IO\MimeTypeDetector;
+use Ibexa\Contracts\Core\Persistence\Content\FieldValue;
 use Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface;
 use Ibexa\Core\Base\Exceptions\InvalidArgumentException;
 use Ibexa\Core\FieldType\Image\Type as ImageType;
@@ -347,6 +348,62 @@ public function provideInputForFromHash(): iterable
         ];
     }
 
+    /**
+     * @phpstan-return iterable<string, array{array<string, mixed>, mixed, mixed}>
+     */
+    public function provideDataForFromPersistenceValue(): iterable
+    {
+        yield 'width and height as empty string are converted to null' => [
+            [
+                'width' => '',
+                'height' => '',
+            ],
+            null,
+            null,
+        ];
+
+        yield 'width and height as zero are preserved' => [
+            [
+                'width' => 0,
+                'height' => '0',
+            ],
+            0,
+            '0',
+        ];
+
+        yield 'width and height as valid values are preserved' => [
+            [
+                'width' => 100,
+                'height' => '200',
+            ],
+            100,
+            '200',
+        ];
+
+        yield 'missing width and height keys default to null' => [
+            [],
+            null,
+            null,
+        ];
+    }
+
+    /**
+     * @param array<string, mixed> $data
+     *
+     * @dataProvider provideDataForFromPersistenceValue
+     */
+    public function testFromPersistenceValue(array $data, mixed $expectedWidth, mixed $expectedHeight): void
+    {
+        $fieldType = $this->getFieldTypeUnderTest();
+
+        $fieldValue = new FieldValue(['data' => $data]);
+        $result = $fieldType->fromPersistenceValue($fieldValue);
+
+        self::assertInstanceOf(ImageValue::class, $result);
+        self::assertSame($expectedWidth, $result->width);
+        self::assertSame($expectedHeight, $result->height);
+    }
+
     protected function provideFieldTypeIdentifier(): string
     {
         return 'ibexa_image';

tests/lib/Persistence/Legacy/FieldValue/Converter/ImageConverterTest.php

@@ -223,6 +223,29 @@ public function xmlToFieldValueProvider(): array
                     ],
                 ]),
             ],
+            'with_empty_width_and_height' => [
+<<< XML
+<?xml version="1.0" encoding="utf-8"?>
+<ezimage serial_number="1" is_valid="1" filename="ibexa_fav.png"
+    suffix="png" basename="ibexa_fav" dirpath="{$dir}" url="{$pathToImg}"
+    original_filename="ibexa_fav.png" mime_type="image/png" width=""
+    height="" alternative_text="test" alias_key="1293033771" timestamp="{timestampToReplace}">
+  <original attribute_id="1" attribute_version="1" attribute_language="eng-GB"/>
+  <information Height="" Width="" IsColor="1"/>
+</ezimage>
+XML,
+                new FieldValue([
+                    'data' => [
+                        'width' => '',
+                        'height' => '',
+                        'alternativeText' => 'test',
+                        'mime' => 'image/png',
+                        'id' => 1,
+                        'fileName' => 'ibexa_fav.png',
+                        'additionalData' => [],
+                    ],
+                ]),
+            ],
         ];
     }
 }