Added missing void return types to CompilerPass implementations (#548)

Author: tbialcz

phpstan-baseline.neon

@@ -4386,12 +4386,6 @@ parameters:
 			count: 1
 			path: src/bundle/IO/DependencyInjection/Compiler/IOConfigurationPass.php
 
-		-
-			message: '#^Method Ibexa\\Bundle\\IO\\DependencyInjection\\Compiler\\IOConfigurationPass\:\:processHandlers\(\) has no return type specified\.$#'
-			identifier: missingType.return
-			count: 1
-			path: src/bundle/IO/DependencyInjection/Compiler/IOConfigurationPass.php
-
 		-
 			message: '#^Method Ibexa\\Bundle\\IO\\DependencyInjection\\Compiler\\IOConfigurationPass\:\:processHandlers\(\) has parameter \$configuredHandlers with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/bundle/IO/DependencyInjection/Compiler/IOConfigurationPass.php

@@ -8,6 +8,7 @@
 namespace Ibexa\Bundle\IO\DependencyInjection\Compiler;
 
 use ArrayObject;
+use Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory;
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
@@ -16,8 +17,6 @@
 use Symfony\Component\DependencyInjection\Reference;
 
 /**
- * This compiler pass will create the metadata and binarydata IO handlers depending on container configuration.
- *
  * @todo Refactor into two passes, since they're very very close.
  */
 class IOConfigurationPass implements CompilerPassInterface
@@ -36,12 +35,7 @@ public function __construct(
         $this->binarydataHandlerFactories = $binarydataHandlerFactories;
     }
 
-    /**
-     * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container
-     *
-     * @throws \LogicException
-     */
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         $ioMetadataHandlers = $container->hasParameter('ibexa.io.metadata_handlers') ?
             $container->getParameter('ibexa.io.metadata_handlers') :
@@ -80,8 +74,8 @@ protected function processHandlers(
         Definition $factory,
         array $configuredHandlers,
         ArrayObject $factories,
-        $defaultHandler
-    ) {
+        string $defaultHandler
+    ): void {
         $handlers = ['default' => new Reference($defaultHandler)];
 
         foreach ($configuredHandlers as $name => $config) {
@@ -105,10 +99,8 @@ protected function processHandlers(
      *
      * @param \Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory[]|\ArrayObject $factories
      * @param string $type
-     *
-     * @return \Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory
      */
-    protected function getFactory(ArrayObject $factories, $type)
+    protected function getFactory(ArrayObject $factories, string $type): ConfigurationFactory
     {
         if (!isset($factories[$type])) {
             throw new InvalidConfigurationException("Unknown handler type $type");

src/bundle/IO/DependencyInjection/Compiler/MigrationFileListerPass.php

@@ -14,12 +14,7 @@
 
 final class MigrationFileListerPass implements CompilerPassInterface
 {
-    /**
-     * Registers the FileListerInterface into the file lister registry.
-     *
-     * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container
-     */
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         if (!$container->has(ConfigurableRegistry::class)) {
             return;