Skip to content

Commit dfeb3c7

Browse files
committed
fix(ci,engine): repoint engine tests/benches to iii_helpers::stream and build helpers before SDK type check
Engine integration tests and benches still imported iii_sdk::UpdateOp, which moved to iii_helpers::stream. The Node CI type-check step now also builds @iii-dev/helpers so its subpath type declarations resolve.
1 parent 699f673 commit dfeb3c7

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -545,8 +545,8 @@ jobs:
545545
#- name: Lint
546546
# run: npx @biomejs/biome check sdk/packages/node
547547

548-
- name: Build observability (prerequisite for type check)
549-
run: pnpm --filter @iii-dev/observability build
548+
- name: Build helper packages (prerequisite for type check)
549+
run: pnpm --filter @iii-dev/observability build && pnpm --filter @iii-dev/helpers build
550550

551551
- name: Type check
552552
run: pnpm --filter iii-sdk exec tsc --noEmit

engine/benches/kv_store_bench.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use std::{sync::Arc, time::Instant};
55
use criterion::{BenchmarkId, Criterion, Throughput, criterion_group, criterion_main};
66
use futures::future::join_all;
77
use iii::builtins::kv::BuiltinKvStore;
8-
use iii_sdk::UpdateOp;
8+
use iii_helpers::stream::UpdateOp;
99
use serde_json::json;
1010
use tokio::runtime::Runtime;
1111

engine/benches/state_adapter_bench.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use std::sync::Arc;
44

55
use criterion::{Criterion, criterion_group, criterion_main};
66
use iii::workers::state::adapters::{StateAdapter, kv_store::BuiltinKvStoreAdapter};
7-
use iii_sdk::UpdateOp;
7+
use iii_helpers::stream::UpdateOp;
88
use serde_json::json;
99
use tokio::runtime::Runtime;
1010

engine/tests/state_stream_update_redis_e2e.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
use serde_json::json;
2020

2121
use iii::workers::state::adapters::{StateAdapter, redis_adapter::StateRedisAdapter};
22-
use iii_sdk::UpdateOp;
22+
use iii_helpers::stream::UpdateOp;
2323

2424
const SCOPE: &str = "audio::transcripts";
2525

0 commit comments

Comments
 (0)