Skip to content

Commit 5e31d8a

Browse files
authored
Merge pull request #353 from inada-s/feat/64bit-used-ms-mask
use uint64 for used_ms_mask
2 parents 4aa8f66 + 6e95747 commit 5e31d8a

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

gdxsv/db.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ type BattleRecord struct {
9090
Frame int `db:"frame" json:"frame,omitempty"`
9191

9292
ReplayURL string `db:"replay_url" json:"replay_url,omitempty"`
93-
UsedMsMask int `db:"used_ms_mask" json:"used_ms_mask,omitempty"`
93+
UsedMsMask uint64 `db:"used_ms_mask" json:"used_ms_mask,omitempty"`
9494
UsedMsList string `db:"used_ms_list" json:"used_ms_list,omitempty"`
9595
RoundWin string `db:"round_win" json:"round_win,omitempty"`
9696
PlayCount int `db:"play_count" json:"play_count,omitempty"`
@@ -278,7 +278,7 @@ type DB interface {
278278
SaveBattleRoundWin(battleCode string, roundWin string) error
279279

280280
// SaveUserUsedMs updates battle_record to set used_ms_mask and used_ms_list for a specific user.
281-
SaveUserUsedMs(battleCode string, userID string, usedMsMask int, usedMsList string) error
281+
SaveUserUsedMs(battleCode string, userID string, usedMsMask uint64, usedMsList string) error
282282

283283
// ResetDailyBattleCount clears daily battle count of all users.
284284
ResetDailyBattleCount() (err error)

gdxsv/db_sqlite.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ WHERE
572572
return err
573573
}
574574

575-
func (db SQLiteDB) SaveUserUsedMs(battleCode string, userID string, usedMsMask int, usedMsList string) error {
575+
func (db SQLiteDB) SaveUserUsedMs(battleCode string, userID string, usedMsMask uint64, usedMsList string) error {
576576
_, err := db.Exec(`
577577
UPDATE battle_record
578578
SET

gdxsv/lbs_handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1759,7 +1759,7 @@ var _ = register(lbsP2PMatchingReport, func(p *LbsPeer, m *LbsMessage) {
17591759
}
17601760

17611761
for posIdx, rec := range records {
1762-
var usedMsMask int
1762+
var usedMsMask uint64
17631763
var usedMsParts []string
17641764
for _, rd := range report.RoundData {
17651765
msID := 0
@@ -1768,7 +1768,7 @@ var _ = register(lbsP2PMatchingReport, func(p *LbsPeer, m *LbsMessage) {
17681768
}
17691769
usedMsParts = append(usedMsParts, strconv.Itoa(msID))
17701770
if msID > 0 {
1771-
usedMsMask |= 1 << msID
1771+
usedMsMask |= 1 << uint(msID)
17721772
}
17731773
}
17741774
usedMsList := strings.Join(usedMsParts, ",")

gdxsv/lbs_handler_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,10 @@ func TestLbs_P2PMatchingReport(t *testing.T) {
128128
assertEq(t, "1,1", rec.RoundWin)
129129
if uid == "U1" {
130130
assertEq(t, "10,11", rec.UsedMsList)
131-
assertEq(t, (1<<10)|(1<<11), rec.UsedMsMask)
131+
assertEq(t, uint64((1<<10)|(1<<11)), rec.UsedMsMask)
132132
} else {
133133
assertEq(t, "20,21", rec.UsedMsList)
134-
assertEq(t, (1<<20)|(1<<21), rec.UsedMsMask)
134+
assertEq(t, uint64((1<<20)|(1<<21)), rec.UsedMsMask)
135135
}
136136
}
137137

0 commit comments

Comments
 (0)