Skip to content

Write more tests around config. validation? #570

@paulo-ferraz-oliveira

Description

@paulo-ferraz-oliveira

I recently pulled for #569, but missed some elements that I didn't want to include yet because they take time, and I wanted to push whatever I had which is already kinda complete in a way.

The missing tests, for that code, are around:

  • are_valid_rulesets (not exhaustive)
  • all_custom_rulesets_have_valid_rules (not exhaustive)
  • no_default_ruleset_override (at least one override try)
  • is_list_of_ignorables (expected to be a list / at least one non-ignorable errors out)
  • all_rules_are_valid (not exhaustive)
  • check_rule_for_options (not exhaustive)

I know that use is already a good source of tests, but wanna include some more to force myself to revisit error messages and usability of the tool.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions