Return owner in batch actions API response (#686)

Author: jakub-id

broker/oapi/open-api.yaml

@@ -1176,6 +1176,9 @@ components:
         id:
           type: string
           description: Unique identifier of the batch action
+        owner:
+          type: string
+          description: Symbol of the institution that owns the batch action. Empty for unrestricted actions created with master access.
         schedule:
           type: string
           description: RRULE schedule expression, e.g. "FREQ=WEEKLY;BYDAY=MO;BYHOUR=6;BYMINUTE=0" (every Monday at 06:00)
@@ -1211,6 +1214,7 @@ components:
           description: Link to execution events for this batch action
       required:
         - id
+        - owner
         - schedule
         - actionName
         - createdAt

broker/scheduler/api/api_handler.go

@@ -349,6 +349,7 @@ func toBatchAction(r *http.Request, task sched_db.ScheduledTask) schedoapi.Batch
 	active := task.Status != sched_db.ScheduledTaskStatusStopped
 	resp := schedoapi.BatchAction{
 		Id:         task.ID,
+		Owner:      task.Owner,
 		Schedule:   task.Schedule,
 		ActionName: schedoapi.BatchActionName(actionData.ActionName),
 		CreatedAt:  task.CreatedAt.Time,

broker/scheduler/api/api_handler_test.go

@@ -152,6 +152,7 @@ func TestGetBatchActions_OK(t *testing.T) {
 	assert.Equal(t, int64(2), resp.About.Count)
 	assert.Len(t, resp.Items, 2)
 	assert.Equal(t, "task-1", resp.Items[0].Id)
+	assert.Equal(t, testSymbol, resp.Items[0].Owner)
 	assert.Equal(t, "https://example.com/batch_actions/task-1/events", resp.Items[0].EventsLink)
 	assert.Equal(t, schedoapi.EmailPullslips, resp.Items[0].ActionName)
 	assert.Equal(t, "title=test", resp.Items[0].BatchQuery)
@@ -360,6 +361,7 @@ func TestPostBatchActions_OK(t *testing.T) {
 	var resp schedoapi.BatchAction
 	assert.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp))
 	assert.NotEmpty(t, resp.Id)
+	assert.Equal(t, testSymbol, resp.Owner)
 	assert.Equal(t, validRrule, resp.Schedule)
 	assert.Equal(t, "title=test", resp.BatchQuery)
 	assert.True(t, resp.Active)
@@ -427,6 +429,7 @@ func TestPostBatchActions_MasterWithoutSymbolCreatesUnrestrictedAction(t *testin
 	var resp schedoapi.BatchAction
 	assert.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp))
 	assert.Equal(t, schedoapi.RequestAging, resp.ActionName)
+	assert.Empty(t, resp.Owner)
 	repo.AssertExpectations(t)
 }
 
@@ -555,6 +558,7 @@ func TestGetBatchActionsId_OK(t *testing.T) {
 	var resp schedoapi.BatchAction
 	assert.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp))
 	assert.Equal(t, "task-1", resp.Id)
+	assert.Equal(t, testSymbol, resp.Owner)
 	assert.Equal(t, "title=test", resp.BatchQuery)
 	assert.True(t, resp.Active)
 	assert.NotNil(t, resp.UpdatedAt)
@@ -614,6 +618,7 @@ func TestPutBatchActionsId_OK_RecomputesRunAtAndPersistsActionData(t *testing.T)
 	assert.Equal(t, http.StatusOK, rr.Code)
 	var resp schedoapi.BatchAction
 	assert.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp))
+	assert.Equal(t, testSymbol, resp.Owner)
 	assert.Equal(t, newSchedule, resp.Schedule)
 	assert.Equal(t, "author=doe", resp.BatchQuery)
 	assert.NotNil(t, resp.NextRun)