CROSSLINK-303 Add state model validation for closing action

Author: JanisSaldabols

broker/patron_request/service/statemodel.go

@@ -184,6 +184,11 @@ func ValidateStateModel(stateModel *proapi.StateModel) error {
 			return fmt.Errorf("primary action %s undefined in state %s side %s", *state.PrimaryAction, state.Name, state.Side)
 		}
 
+		if state.ClosingAction != nil && (state.Actions == nil || !slices.ContainsFunc(*state.Actions, func(a proapi.ModelAction) bool {
+			return a.Name == string(*state.ClosingAction)
+		})) {
+			return fmt.Errorf("closing action %s undefined in state %s side %s", *state.ClosingAction, state.Name, state.Side)
+		}
 		if state.Events != nil {
 			for _, event := range *state.Events {
 				if !slices.Contains(allowedEvents, event.Name) {

broker/patron_request/service/statemodel_test.go

@@ -200,6 +200,55 @@ func TestValidateStateModelPrimaryActionNoActionsDefined(t *testing.T) {
 	assert.Equal(t, "primary action other undefined in state NEW side REQUESTER", err.Error())
 }
 
+func TestValidateStateModelClosingActionUndefined(t *testing.T) {
+	s := "ship"
+	valid := "will-supply"
+	tt := true
+	model := &proapi.StateModel{
+		Type:    proapi.StateModelTypeStateModel,
+		Name:    "test",
+		Version: "1.0.0",
+		States: []proapi.ModelState{
+			{
+				Name:    "VALIDATED",
+				Side:    proapi.SUPPLIER,
+				Initial: &tt,
+				Actions: &[]proapi.ModelAction{
+					{Name: valid},
+				},
+				PrimaryAction: &valid,
+				ClosingAction: &s,
+			},
+		},
+	}
+
+	err := ValidateStateModel(model)
+	assert.Error(t, err)
+	assert.Equal(t, "closing action ship undefined in state VALIDATED side SUPPLIER", err.Error())
+}
+
+func TestValidateStateModelClosingActionNoActionsDefined(t *testing.T) {
+	s := "ship"
+	tt := true
+	model := &proapi.StateModel{
+		Type:    proapi.StateModelTypeStateModel,
+		Name:    "test",
+		Version: "1.0.0",
+		States: []proapi.ModelState{
+			{
+				Name:          "VALIDATED",
+				Side:          proapi.SUPPLIER,
+				Initial:       &tt,
+				ClosingAction: &s,
+			},
+		},
+	}
+
+	err := ValidateStateModel(model)
+	assert.Error(t, err)
+	assert.Equal(t, "closing action ship undefined in state VALIDATED side SUPPLIER", err.Error())
+}
+
 func TestValidateStateModelManualCloseTerminal(t *testing.T) {
 	tt := true
 	model := &proapi.StateModel{