Merge pull request #6 from infection/add-type-declaration

Add property type declaration instead of doc-blocks

Author: maks-rafalko

src/CommandLineBuilder.php

@@ -46,7 +46,7 @@ final class CommandLineBuilder
     /**
      * @var string[]|null
      */
-    private $cachedPhpCmdLine;
+    private ?array $cachedPhpCmdLine = null;
 
     /**
      * @param string[] $frameworkArgs

src/Config/AbstractYamlConfiguration.php

@@ -42,19 +42,14 @@
  */
 abstract class AbstractYamlConfiguration
 {
-    /**
-     * @var string
-     */
-    protected $tempDirectory;
+    protected string $tempDirectory;
 
     /**
      * @var array<string, mixed>
      */
-    protected $parsedYaml;
+    protected array $parsedYaml;
 
     /**
-     * AbstractYamlConfiguration constructor.
-     *
      * @param array<string, mixed> $parsedYaml
      */
     public function __construct(string $tmpDir, array $parsedYaml)

src/Config/Builder/InitialConfigBuilder.php

@@ -43,9 +43,9 @@
  */
 class InitialConfigBuilder
 {
-    private $tempDirectory;
-    private $originalYamlConfigPath;
-    private $skipCoverage;
+    private string $tempDirectory;
+    private string $originalYamlConfigPath;
+    private bool $skipCoverage;
 
     public function __construct(string $tempDirectory, string $originalYamlConfigPath, bool $skipCoverage)
     {

src/Config/Builder/MutationConfigBuilder.php

@@ -47,9 +47,9 @@
  */
 class MutationConfigBuilder
 {
-    private $tempDirectory;
-    private $originalYamlConfigPath;
-    private $projectDir;
+    private string $tempDirectory;
+    private string $originalYamlConfigPath;
+    private string $projectDir;
 
     public function __construct(string $tempDirectory, string $originalYamlConfigPath, string $projectDir)
     {

src/Config/InitialYamlConfiguration.php

@@ -43,7 +43,7 @@
  */
 final class InitialYamlConfiguration extends AbstractYamlConfiguration
 {
-    private $skipCoverage;
+    private bool $skipCoverage;
 
     /**
      * @param array<string, mixed> $parsedYaml

src/Config/MutationYamlConfiguration.php

@@ -42,7 +42,7 @@
  */
 final class MutationYamlConfiguration extends AbstractYamlConfiguration
 {
-    private $customAutoloadFilePath;
+    private string $customAutoloadFilePath;
 
     /**
      * @param array<string, mixed> $parsedYaml

src/PhpSpecAdapter.php

@@ -52,12 +52,12 @@ final class PhpSpecAdapter implements TestFrameworkAdapter
         '/Fatal error happened/i',
     ];
 
-    private $testFrameworkExecutable;
-    private $argumentsAndOptionsBuilder;
-    private $initialConfigBuilder;
-    private $mutationConfigBuilder;
-    private $versionParser;
-    private $commandLineBuilder;
+    private string $testFrameworkExecutable;
+    private ArgumentsAndOptionsBuilder $argumentsAndOptionsBuilder;
+    private InitialConfigBuilder $initialConfigBuilder;
+    private MutationConfigBuilder $mutationConfigBuilder;
+    private VersionParser $versionParser;
+    private CommandLineBuilder $commandLineBuilder;
     private ?string $cachedVersion = null;
 
     public function __construct(

tests/phpunit/Config/InitialYamlConfigurationTest.php

@@ -43,15 +43,12 @@
 
 final class InitialYamlConfigurationTest extends TestCase
 {
-    /**
-     * @var string
-     */
-    private $tempDir = '/path/to/tmp';
+    private string $tempDir = '/path/to/tmp';
 
     /**
      * @var array<string, mixed>
      */
-    private $defaultConfig = [
+    private array $defaultConfig = [
         'extensions' => [
             'SomeOtherExtension' => [],
             'PhpSpecCodeCoverageExtension' => [

tests/phpunit/Config/MutationYamlConfigurationTest.php

@@ -41,20 +41,14 @@
 
 final class MutationYamlConfigurationTest extends TestCase
 {
-    /**
-     * @var string
-     */
-    private $tempDir = '/path/to/tmp';
+    private string $tempDir = '/path/to/tmp';
 
-    /**
-     * @var string
-     */
-    private $customAutoloadFilePath = '/custom/path';
+    private string $customAutoloadFilePath = '/custom/path';
 
     /**
      * @var array<string, mixed>
      */
-    private $defaultConfig = [
+    private array $defaultConfig = [
         'extensions' => [
             'FirstExtension' => [],
             'PhpSpecCodeCoverageExtension' => [

tests/phpunit/FileSystem/FileSystemTestCase.php

@@ -60,15 +60,8 @@ abstract class FileSystemTestCase extends TestCase
 {
     private const TMP_DIR_NAME = 'infection-test';
 
-    /**
-     * @var string
-     */
-    protected $cwd;
-
-    /**
-     * @var string
-     */
-    protected $tmp;
+    protected string $cwd;
+    protected string $tmp;
 
     public static function tearDownAfterClass(): void
     {