[FIX] account_payment_pro: remove state from constraint on to_pay_move_line_ids

Allow resetting to draft when a payment has inconsistent 'to_pay_move_line_ids' that were previously modified.

Removing 'state' from the constraint dependencies prevents validation errors during the
'reset to draft' flow of an invoice.
This issue occurs when to pay move lines initially created with the payment's account are later modified to a different account.
By removing the state trigger, we avoid re-validating account consistency during state transitions
that don't involve line modifications.

Steps to Reproduce
1. Create and Post an Invoice:

2. Register a Payment with multiple To Pay move lines:

Click on Register Payment from the invoice.

3. Manually Modify an un-reconciled To Pay move line:
Exaple: Change the Account of this specific line to a different one (e.g., from "Receivable" to "Other Current Assets").

4.Go back to the original Invoice (the one reconciled with the payment).

5. Click the Reset to Draft button.

closes #967

Signed-off-by: Juan José Scarafía <jjs@adhoc.com.ar>

Author: rov-adhoc

account_payment_pro/models/account_payment.py

@@ -150,7 +150,7 @@ def _compute_write_off_available(self):
                 rec.env["account.write_off.type"].search([("company_ids", "=", rec.company_id.id)], limit=1)
             )
 
-    @api.constrains("to_pay_move_line_ids", "state")
+    @api.constrains("to_pay_move_line_ids")
     def _check_to_pay_lines_account(self):
         """TODO ver si esto tmb lo llevamos a la UI y lo mostramos como un warning.
         tmb podemos dar mas info al usuario en el error"""
@@ -662,6 +662,7 @@ def _reconcile_after_post(self):
 
     def action_post(self):
         res = super().action_post()
+        self._check_to_pay_lines_account()
         self._reconcile_after_post()
         return res