Skip to content

Commit 46f1b98

Browse files
Juan Ignacio Carrerasles-adhoc
authored andcommitted
[FIX] stock_ux: remove non-functional scrap quantity guard
The action_validate() override on stock.scrap tried to prevent scrapping more than the transfer quantity, but scrap moves are created with picking_id set, so they count towards total_picking and the cap rises with every scrap. It only blocked a single scrap larger than the total, letting the cumulative case through. It also diverges from Odoo, which is deliberately permissive here (the return wizard caps nothing). Removed the override and its orphaned translation. closes #998 Signed-off-by: Matias Velazquez <mav@adhoc.com.ar>
1 parent 0e9da7f commit 46f1b98

4 files changed

Lines changed: 1 addition & 43 deletions

File tree

stock_ux/__manifest__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
##############################################################################
2020
{
2121
"name": "Stock UX",
22-
"version": "18.0.1.11.0",
22+
"version": "18.0.1.12.0",
2323
"category": "Warehouse Management",
2424
"sequence": 14,
2525
"summary": "",

stock_ux/i18n/es.po

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -491,14 +491,6 @@ msgstr "Cantidad Neta"
491491
msgid "Net Quantity Location"
492492
msgstr "Cantidad neta en ubicación"
493493

494-
#. module: stock_ux
495-
#. odoo-python
496-
#: code:addons/stock_ux/models/stock_scrap.py:0
497-
msgid ""
498-
"No se puede desechar una cantidad mayor a la cantidad dentro de la "
499-
"transferencia del producto: %s."
500-
msgstr ""
501-
502494
#. module: stock_ux
503495
#: model_terms:ir.actions.act_window,help:stock_ux.action_picking_tree_all
504496
msgid "No transfer found. Let's create one!"
@@ -745,11 +737,6 @@ msgstr "Error de entrega de SMS"
745737
msgid "Scheduled Date"
746738
msgstr "Fecha Programada"
747739

748-
#. module: stock_ux
749-
#: model:ir.model,name:stock_ux.model_stock_scrap
750-
msgid "Scrap"
751-
msgstr "Desechar"
752-
753740
#. module: stock_ux
754741
#: model:ir.actions.server,name:stock_ux.action_operation_set_all_undone
755742
msgid "Set all undone"

stock_ux/models/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@
1313
from . import res_company
1414
from . import res_config_settings
1515
from . import stock_rule
16-
from . import stock_scrap
1716
from . import stock_location
1817
from . import stock_forecasted

stock_ux/models/stock_scrap.py

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)