build: order clang warning suppressions

Author: darwin67

CMakeLists.txt

@@ -44,8 +44,6 @@ include(limit_jobs)
 # Configure Seastar compile options to align with Scylla
 if(DEFINED ENV{NIX_CC})
   add_compile_options(-DFMT_CONSTEVAL=)
-  add_compile_options(-Wno-deprecated-literal-operator)
-  add_compile_options(-Wno-unused-private-field)
 endif()
 set(CMAKE_CXX_STANDARD "23" CACHE INTERNAL "")
 set(CMAKE_CXX_EXTENSIONS ON CACHE INTERNAL "")

cmake/mode.common.cmake

@@ -4,8 +4,10 @@ set(disabled_warnings
   mismatched-tags
   missing-field-initializers
   overloaded-virtual
+  deprecated-literal-operator
   unsupported-friend
   enum-constexpr-conversion
+  unused-private-field
   unused-parameter)
 include(CheckCXXCompilerFlag)
 foreach(warning ${disabled_warnings})

configure.py

@@ -1548,6 +1548,8 @@ def get_warning_options(cxx):
         '-Wno-unsupported-friend',
         '-Wno-missing-field-initializers',
         '-Wno-deprecated-copy',
+        '-Wno-deprecated-literal-operator',
+        '-Wno-unused-private-field',
         # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77728
         '-Wno-psabi',
         '-Wno-enum-constexpr-conversion',
@@ -1676,7 +1678,7 @@ def dynamic_linker_option():
     user_cflags += ' -march=' + args.target
 
 if os.environ.get('NIX_CC'):
-    user_cflags += ' -DFMT_CONSTEVAL= -Wno-deprecated-literal-operator -Wno-unused-private-field'
+    user_cflags += ' -DFMT_CONSTEVAL='
 
 user_cflags = user_cflags.strip()