Skip to content

Commit 7a9202f

Browse files
author
Scott Basse
committed
PR Review Comments Notifications:
- Don't notify about new review comments once the PR is mergeable as a notification with link attached is already send out for this - Send notification to original PR author and not the author of the slack message - Make PR title bold in message
1 parent 3d237b6 commit 7a9202f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

command/pullrequest/pull_request.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ func (c command) GetHelp() []bot.Help {
378378
}
379379

380380
func (c *command) notifyNewReviewComments(prw *pullRequestWatch) {
381-
if !c.cfg.Notifications.NewReviewComments.IsEnabled() {
381+
if !c.cfg.Notifications.NewReviewComments.IsEnabled() || prw.DidNotifyMergeable {
382382
return
383383
}
384384

@@ -388,5 +388,5 @@ func (c *command) notifyNewReviewComments(prw *pullRequestWatch) {
388388

389389
prw.SavedLatestReviewCommentTimestamp = prw.PullRequest.LatestReviewCommentsTimestamp
390390

391-
c.sendPrivateMessage(prw.Author, "PR '%s' \nNew review comments were added: %s", prw.PullRequest.Name, getPRLinkMessage(prw))
391+
c.sendPrivateMessage(prw.PullRequest.Author, "PR *'%s'* \nNew review comments were added: %s", prw.PullRequest.Name, getPRLinkMessage(prw))
392392
}

0 commit comments

Comments
 (0)