Commit 0a8a30e
Joe Hernandez
Return file's media_entry_id in response
fixes MAT-959
flag=none
Test Plan 1: Backwards compatibility
- Get the changes in this commit locally in your RCS
- In your local canvas, run a recent version of master
- In canvas, go to an RCE
- From tools menu: Insert > Document > Course documents
- In the dropdown that says "Document", change to "All"
- Select a file from either "Course files" or "My files"
VERIFY:
- file is properly embedded in the RCE.
Test Plan 2: Together with corresponding changes in the canvas-lms repo
- https://gerrit.instructure.com/c/canvas-lms/+/305518
- follow the test plan outlined in that commit
Change-Id: I4aeaf098c8192d9664f7ef89cfa89466d328a5c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-rce-api/+/305519
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Joe Hernandez <joe.hernandez@instructure.com>1 parent 42c7ca8 commit 0a8a30e
2 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
| 119 | + | |
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
| |||
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
142 | | - | |
| 143 | + | |
| 144 | + | |
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
| |||
156 | 158 | | |
157 | 159 | | |
158 | 160 | | |
| 161 | + | |
159 | 162 | | |
160 | 163 | | |
161 | 164 | | |
| |||
170 | 173 | | |
171 | 174 | | |
172 | 175 | | |
173 | | - | |
| 176 | + | |
| 177 | + | |
174 | 178 | | |
175 | 179 | | |
176 | 180 | | |
| |||
0 commit comments