Merge pull request #396 from intellectronica/copilot/fix-install-skills-functionality

Add Junie native skills propagation to `.junie/skills`

Fixes #395

Author: intellectronica

README.md

@@ -73,7 +73,7 @@ Ruler solves this by providing a **single source of truth** for all your AI agen
 | Firebase Studio        | `.idx/airules.md`                              | `.idx/mcp.json`                                  | -                         |
 | Open Hands             | `.openhands/microagents/repo.md`               | `config.toml`                                    | -                         |
 | Gemini CLI             | `AGENTS.md`                                    | `.gemini/settings.json`                          | `.gemini/skills/`         |
-| Junie                  | `.junie/guidelines.md`                         | `.junie/mcp/mcp.json`                            | -                         |
+| Junie                  | `.junie/guidelines.md`                         | `.junie/mcp/mcp.json`                            | `.junie/skills/`          |
 | AugmentCode            | `.augment/rules/ruler_augment_instructions.md` | -                                                | -                         |
 | Kilo Code              | `AGENTS.md`                                    | `.kilocode/mcp.json`                             | `.claude/skills/`         |
 | OpenCode               | `AGENTS.md`                                    | `opencode.json`                                  | `.opencode/skills/`       |
@@ -325,15 +325,15 @@ ruler revert [options]
 
 ### Options
 
-| Option                         | Description                                                                                                                                                                                                                                                                                                      |
-| ------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `--project-root <path>`        | Path to your project's root (default: current directory)                                                                                                                                                                                                                                                         |
+| Option                         | Description                                                                                                                                                                                                                                                                                                                    |
+| ------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+| `--project-root <path>`        | Path to your project's root (default: current directory)                                                                                                                                                                                                                                                                       |
 | `--agents <agent1,agent2,...>` | Comma-separated list of agent names to revert (agentsmd, aider, amazonqcli, amp, antigravity, augmentcode, claude, cline, codex, copilot, crush, cursor, factory, firebase, firebender, gemini-cli, goose, jetbrains-ai, jules, junie, kilocode, kiro, mistral, opencode, openhands, pi, qwen, roo, trae, warp, windsurf, zed) |
-| `--config <path>`              | Path to a custom `ruler.toml` configuration file                                                                                                                                                                                                                                                                 |
-| `--keep-backups`               | Keep backup files (.bak) after restoration (default: false)                                                                                                                                                                                                                                                      |
-| `--dry-run`                    | Preview changes without actually reverting files                                                                                                                                                                                                                                                                 |
-| `--verbose` / `-v`             | Display detailed output during execution                                                                                                                                                                                                                                                                         |
-| `--local-only`                 | Only search for local .ruler directories, ignore global config                                                                                                                                                                                                                                                   |
+| `--config <path>`              | Path to a custom `ruler.toml` configuration file                                                                                                                                                                                                                                                                               |
+| `--keep-backups`               | Keep backup files (.bak) after restoration (default: false)                                                                                                                                                                                                                                                                    |
+| `--dry-run`                    | Preview changes without actually reverting files                                                                                                                                                                                                                                                                               |
+| `--verbose` / `-v`             | Display detailed output during execution                                                                                                                                                                                                                                                                                       |
+| `--local-only`                 | Only search for local .ruler directories, ignore global config                                                                                                                                                                                                                                                                 |
 
 ### Common Examples
 
@@ -594,6 +594,7 @@ Skills are specialized knowledge packages that extend AI agent capabilities with
   - **Mistral Vibe**: `.vibe/skills/`
   - **Roo Code**: `.roo/skills/`
   - **Gemini CLI**: `.gemini/skills/`
+  - **Junie**: `.junie/skills/`
   - **Cursor**: `.cursor/skills/`
 
 ### Skills Directory Structure
@@ -659,13 +660,14 @@ When skills support is enabled and gitignore integration is active, Ruler automa
 - `.vibe/skills/` (for Mistral Vibe)
 - `.roo/skills/` (for Roo Code)
 - `.gemini/skills/` (for Gemini CLI)
+- `.junie/skills/` (for Junie)
 - `.cursor/skills/` (for Cursor)
 
 to your `.gitignore` file within the managed Ruler block.
 
 ### Requirements
 
-- **For agents with native skills support** (Claude Code, GitHub Copilot, Kilo Code, OpenAI Codex CLI, OpenCode, Pi Coding Agent, Goose, Amp, Antigravity, Factory Droid, Mistral Vibe, Roo Code, Gemini CLI, Cursor): No additional requirements.
+- **For agents with native skills support** (Claude Code, GitHub Copilot, Kilo Code, OpenAI Codex CLI, OpenCode, Pi Coding Agent, Goose, Amp, Antigravity, Factory Droid, Mistral Vibe, Roo Code, Gemini CLI, Junie, Cursor): No additional requirements.
 
 ### Validation
 
@@ -718,6 +720,7 @@ ruler apply
 #    - Mistral Vibe: .vibe/skills/my-skill/
 #    - Roo Code: .roo/skills/my-skill/
 #    - Gemini CLI: .gemini/skills/my-skill/
+#    - Junie: .junie/skills/my-skill/
 #    - Cursor: .cursor/skills/my-skill/
 ```
 

src/agents/JunieAgent.ts

@@ -24,4 +24,8 @@ export class JunieAgent extends AbstractAgent {
   supportsMcpRemote(): boolean {
     return true;
   }
+
+  supportsNativeSkills(): boolean {
+    return true;
+  }
 }

src/constants.ts

@@ -63,6 +63,7 @@ export const GOOSE_SKILLS_PATH = '.agents/skills';
 export const VIBE_SKILLS_PATH = '.vibe/skills';
 export const ROO_SKILLS_PATH = '.roo/skills';
 export const GEMINI_SKILLS_PATH = '.gemini/skills';
+export const JUNIE_SKILLS_PATH = '.junie/skills';
 export const CURSOR_SKILLS_PATH = '.cursor/skills';
 export const FACTORY_SKILLS_PATH = '.factory/skills';
 export const ANTIGRAVITY_SKILLS_PATH = '.agent/skills';

src/core/SkillsProcessor.ts

@@ -11,6 +11,7 @@ import {
   VIBE_SKILLS_PATH,
   ROO_SKILLS_PATH,
   GEMINI_SKILLS_PATH,
+  JUNIE_SKILLS_PATH,
   CURSOR_SKILLS_PATH,
   FACTORY_SKILLS_PATH,
   ANTIGRAVITY_SKILLS_PATH,
@@ -68,6 +69,7 @@ export async function getSkillsGitignorePaths(
     VIBE_SKILLS_PATH,
     ROO_SKILLS_PATH,
     GEMINI_SKILLS_PATH,
+    JUNIE_SKILLS_PATH,
     CURSOR_SKILLS_PATH,
     FACTORY_SKILLS_PATH,
     ANTIGRAVITY_SKILLS_PATH,
@@ -83,6 +85,7 @@ export async function getSkillsGitignorePaths(
     vibe: VIBE_SKILLS_PATH,
     roo: ROO_SKILLS_PATH,
     gemini: GEMINI_SKILLS_PATH,
+    junie: JUNIE_SKILLS_PATH,
     cursor: CURSOR_SKILLS_PATH,
     factory: FACTORY_SKILLS_PATH,
     antigravity: ANTIGRAVITY_SKILLS_PATH,
@@ -125,6 +128,7 @@ type SkillTarget =
   | 'vibe'
   | 'roo'
   | 'gemini'
+  | 'junie'
   | 'cursor'
   | 'factory'
   | 'antigravity';
@@ -138,6 +142,7 @@ const SKILL_TARGET_TO_IDENTIFIERS = new Map<SkillTarget, readonly string[]>([
   ['vibe', ['mistral']],
   ['roo', ['roo']],
   ['gemini', ['gemini-cli']],
+  ['junie', ['junie']],
   ['cursor', ['cursor']],
   ['factory', ['factory']],
   ['antigravity', ['antigravity']],
@@ -177,6 +182,7 @@ async function cleanupSkillsDirectories(
   const vibeSkillsPath = path.join(projectRoot, VIBE_SKILLS_PATH);
   const rooSkillsPath = path.join(projectRoot, ROO_SKILLS_PATH);
   const geminiSkillsPath = path.join(projectRoot, GEMINI_SKILLS_PATH);
+  const junieSkillsPath = path.join(projectRoot, JUNIE_SKILLS_PATH);
   const cursorSkillsPath = path.join(projectRoot, CURSOR_SKILLS_PATH);
   const factorySkillsPath = path.join(projectRoot, FACTORY_SKILLS_PATH);
   const antigravitySkillsPath = path.join(projectRoot, ANTIGRAVITY_SKILLS_PATH);
@@ -349,6 +355,27 @@ async function cleanupSkillsDirectories(
     // Directory doesn't exist, nothing to clean
   }
 
+  // Clean up .junie/skills
+  try {
+    await fs.access(junieSkillsPath);
+    if (dryRun) {
+      logVerboseInfo(
+        `DRY RUN: Would remove ${JUNIE_SKILLS_PATH}`,
+        verbose,
+        dryRun,
+      );
+    } else {
+      await fs.rm(junieSkillsPath, { recursive: true, force: true });
+      logVerboseInfo(
+        `Removed ${JUNIE_SKILLS_PATH} (skills disabled)`,
+        verbose,
+        dryRun,
+      );
+    }
+  } catch {
+    // Directory doesn't exist, nothing to clean
+  }
+
   // Clean up .cursor/skills
   try {
     await fs.access(cursorSkillsPath);
@@ -573,6 +600,15 @@ export async function propagateSkills(
     await propagateSkillsForGemini(projectRoot, { dryRun });
   }
 
+  if (selectedTargets.has('junie')) {
+    logVerboseInfo(
+      `Copying skills to ${JUNIE_SKILLS_PATH} for Junie`,
+      verbose,
+      dryRun,
+    );
+    await propagateSkillsForJunie(projectRoot, { dryRun });
+  }
+
   if (selectedTargets.has('cursor')) {
     logVerboseInfo(
       `Copying skills to ${CURSOR_SKILLS_PATH} for Cursor`,
@@ -1067,6 +1103,55 @@ export async function propagateSkillsForGemini(
   return [];
 }
 
+/**
+ * Propagates skills for Junie by copying .ruler/skills to .junie/skills.
+ * Uses atomic replace to ensure safe overwriting of existing skills.
+ * Returns dry-run steps if dryRun is true, otherwise returns empty array.
+ */
+export async function propagateSkillsForJunie(
+  projectRoot: string,
+  options: { dryRun: boolean },
+): Promise<string[]> {
+  const skillsDir = path.join(projectRoot, RULER_SKILLS_PATH);
+  const junieSkillsPath = path.join(projectRoot, JUNIE_SKILLS_PATH);
+  const junieDir = path.dirname(junieSkillsPath);
+
+  try {
+    await fs.access(skillsDir);
+  } catch {
+    return [];
+  }
+
+  if (options.dryRun) {
+    return [`Copy skills from ${RULER_SKILLS_PATH} to ${JUNIE_SKILLS_PATH}`];
+  }
+
+  await fs.mkdir(junieDir, { recursive: true });
+
+  const tempDir = path.join(junieDir, `skills.tmp-${Date.now()}`);
+
+  try {
+    await copySkillsDirectory(skillsDir, tempDir);
+
+    try {
+      await fs.rm(junieSkillsPath, { recursive: true, force: true });
+    } catch {
+      // Target didn't exist, that's fine
+    }
+
+    await fs.rename(tempDir, junieSkillsPath);
+  } catch (error) {
+    try {
+      await fs.rm(tempDir, { recursive: true, force: true });
+    } catch {
+      // Ignore cleanup errors
+    }
+    throw error;
+  }
+
+  return [];
+}
+
 /**
  * Propagates skills for Cursor by copying .ruler/skills to .cursor/skills.
  * Uses atomic replace to ensure safe overwriting of existing skills.