chore(installations): deprecations for v8 API ahead of future major release

Author: MichaelVerdon

packages/app/lib/common/index.js

@@ -345,6 +345,23 @@ const mapOfDeprecationReplacements = {
       nanoseconds: NO_REPLACEMENT,
     },
   },
+  functions: {
+    default: {
+      useEmulator: 'connectFirestoreEmulator()',
+      httpsCallable: 'httpsCallable()',
+      httpsCallableFromUrl: 'httpsCallableFromUrl()',
+    },
+    statics: {
+      HttpsErrorCode: 'HttpsErrorCode',
+    },
+  },
+  installations: {
+    default: {
+      delete: 'deleteInstallations()',
+      getId: 'getId()',
+      getToken: 'getToken()',
+    },
+  },
   messaging: {
     default: {
       isAutoInitEnabled: 'isAutoInitEnabled()',
@@ -437,16 +454,6 @@ const mapOfDeprecationReplacements = {
       TaskState: 'TaskState',
     },
   },
-  functions: {
-    default: {
-      useEmulator: 'connectFirestoreEmulator()',
-      httpsCallable: 'httpsCallable()',
-      httpsCallableFromUrl: 'httpsCallableFromUrl()',
-    },
-    statics: {
-      HttpsErrorCode: 'HttpsErrorCode',
-    },
-  },
 };
 
 const modularDeprecationMessage =

packages/installations/__tests__/installations.test.ts

@@ -1,4 +1,4 @@
-import { afterAll, beforeAll, describe, expect, it } from '@jest/globals';
+import { afterAll, beforeAll, describe, expect, it, beforeEach, jest } from '@jest/globals';
 
 import {
   firebase,
@@ -9,6 +9,14 @@ import {
   onIdChange,
 } from '../lib';
 
+import {
+  createCheckV9Deprecation,
+  CheckV9DeprecationFunction,
+} from '../../app/lib/common/unitTestUtils';
+
+// @ts-ignore test
+import FirebaseModule from '../../app/lib/internal/FirebaseModule';
+
 describe('installations()', function () {
   describe('namespace', function () {
     beforeAll(async function () {
@@ -76,4 +84,52 @@ describe('installations()', function () {
       });
     });
   });
+
+  describe('test `console.warn` is called for RNFB v8 API & not called for v9 API', function () {
+    let installationsV9Deprecation: CheckV9DeprecationFunction;
+
+    beforeEach(function () {
+      installationsV9Deprecation = createCheckV9Deprecation(['installations']);
+
+      // @ts-ignore test
+      jest.spyOn(FirebaseModule.prototype, 'native', 'get').mockImplementation(() => {
+        return new Proxy(
+          {},
+          {
+            get: () =>
+              jest.fn().mockResolvedValue({
+                constants: {},
+              } as never),
+          },
+        );
+      });
+    });
+
+    it('delete', function () {
+      const installations = getInstallations();
+      installationsV9Deprecation(
+        () => deleteInstallations(installations),
+        () => installations.delete(),
+        'delete',
+      );
+    });
+
+    it('getId', function () {
+      const installations = getInstallations();
+      installationsV9Deprecation(
+        () => getId(installations),
+        () => installations.getId(),
+        'getId',
+      );
+    });
+
+    it('getToken', function () {
+      const installations = getInstallations();
+      installationsV9Deprecation(
+        () => getToken(installations),
+        () => installations.getToken(),
+        'getToken',
+      );
+    });
+  });
 });

packages/installations/lib/modular/index.js

@@ -16,7 +16,7 @@
  */
 
 import { getApp } from '@react-native-firebase/app';
-
+import { MODULAR_DEPRECATION_ARG } from '@react-native-firebase/app/lib/common';
 /**
  * @typedef {import('..').FirebaseInstallationsTypes.Module} FirebaseInstallation
  */
@@ -33,15 +33,15 @@ export function getInstallations(app) {
  * @returns {Promise<void>}
  */
 export function deleteInstallations(installations) {
-  return installations.delete();
+  return installations.delete.call(installations, MODULAR_DEPRECATION_ARG);
 }
 
 /**
  * @param {FirebaseInstallation} installations
  * @returns {Promise<string>}
  */
 export function getId(installations) {
-  return installations.getId();
+  return installations.getId.call(installations, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -50,7 +50,7 @@ export function getId(installations) {
  * @returns {Promise<string>}
  */
 export function getToken(installations, forceRefresh) {
-  return installations.getToken(forceRefresh);
+  return installations.getToken.call(installations, forceRefresh, MODULAR_DEPRECATION_ARG);
 }
 
 /**