Skip to content

Commit bcc75b2

Browse files
committed
chore(repo): refine Gemini review style guide
1 parent 2733d9b commit bcc75b2

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

.gemini/styleguide.md

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,27 @@ If no root `AGENTS.md` file exists, use the guidance below.
66

77
## Review priorities
88

9-
- Prioritize correctness, regressions, and unsafe changes over style-only feedback.
10-
- Prefer concise, actionable comments with specific suggestions.
11-
- Avoid low-value nits unless they materially affect readability or consistency.
9+
- Prioritize correctness, regressions, crash risks, unsafe assumptions, and API mismatches over style-only feedback.
10+
- Prefer concise, actionable comments with concrete suggestions.
11+
- Avoid low-value nits unless they materially affect readability, consistency, or user-facing meaning.
1212

13-
## Repository expectations
13+
## React Native Firebase expectations
1414

1515
- Prefer consistency with existing patterns already used in the affected package or area.
16-
- Flag public API changes that should also update types, tests, or documentation.
17-
- Flag platform gaps when a change appears to require both iOS and Android support.
18-
- Prefer alignment with the Firebase Web SDK where that is the established project pattern.
16+
- Prefer alignment with the Firebase Web SDK for public API shape and behavior unless a difference is intentional and documented.
17+
- Flag public API changes that should also update TypeScript types, docs, and tests.
18+
- Flag platform gaps when a feature or fix appears to require both iOS and Android support.
19+
- If an API is platform-specific, check that the documentation and typings make that clear.
20+
- Prefer native method names that match the JavaScript API name where practical.
1921

2022
## Testing expectations
2123

2224
- Suggest tests when behavior changes or regression risk increases.
25+
- Prefer focused tests near the changed package rather than broad new coverage.
2326
- Avoid asking for redundant tests when existing coverage already appears sufficient.
27+
28+
## Comment behavior
29+
30+
- Do not prioritize naming, formatting, or markdown wording comments ahead of correctness issues.
31+
- Do not comment on docs-only wording unless it changes meaning or could mislead users.
32+
- When a public API changes, prefer one combined comment covering types, docs, and tests instead of multiple fragmented comments.

0 commit comments

Comments
 (0)