test(types): correctly error / print stale entries that are resolved

noticed that despite ListenSource being a fresh implementation that
fixed a gap between firebase-js-sdk and react-native-firebase that
yarn compare:types was still green

it should have failed and notified us that we had stale entries to
clean up, now it will

Author: mikehardy

.github/scripts/compare-types/packages/firestore/config.ts

@@ -140,12 +140,6 @@ const config: PackageConfig = {
         'Type used with setIndexConfiguration. Not implemented in RN Firebase ' +
         'as setIndexConfiguration is not supported.',
     },
-    {
-      name: 'ListenSource',
-      reason:
-        'Union type for snapshot listener source (default, server, cache). ' +
-        'Not yet implemented in RN Firebase; listeners always use default behaviour.',
-    },
     {
       name: 'MemoryCacheSettings',
       reason:
@@ -320,12 +314,6 @@ const config: PackageConfig = {
         'firebase-js-sdk public type. These are structural artifacts of the ' +
         'RN implementation.',
     },
-    {
-      name: 'SnapshotListenOptions',
-      reason:
-        'The firebase-js-sdk includes an optional `source` property (of type ' +
-        '`ListenSource`) which is not yet supported in RN Firebase.',
-    },
     // --- Wrapper classes (same public API, different structure: getters vs properties, readonly, toJSON/fromJSON) ---
     {
       name: 'DocumentReference',

.github/scripts/compare-types/src/index.ts

@@ -9,7 +9,8 @@
  *
  * Exit codes:
  *   0 — all differences are documented in the package config files
- *   1 — undocumented differences found (or a required file is missing)
+ *   1 — undocumented differences, stale registry entries in config (resolved
+ *       APIs still listed as missing/extra/different), or a required file missing
  */
 
 import fs from 'fs';

.github/scripts/compare-types/src/report.ts

@@ -48,14 +48,71 @@ function printSection(
   }
 }
 
+// ---------------------------------------------------------------------------
+// Stale registry (documented differences that no longer apply)
+// ---------------------------------------------------------------------------
+
+function countStale(result: ComparisonResult): number {
+  return (
+    result.staleConfigMissing.length +
+    result.staleConfigExtra.length +
+    result.staleConfigDifferentShape.length
+  );
+}
+
+/**
+ * Prints stale `config.ts` entries and returns how many were printed.
+ * These must run even when there are zero live diffs, otherwise a resolved
+ * API (e.g. an export removed from `missingInRN` in reality) would never
+ * force updating the comparison registry.
+ */
+function printStaleRegistrySection(result: ComparisonResult): number {
+  const totalStale = countStale(result);
+  if (totalStale === 0) {
+    return 0;
+  }
+
+  console.log(`\n  ${c(RED, `Stale registry / config entries`)} (${totalStale}):`);
+
+  for (const name of result.staleConfigMissing) {
+    console.log(
+      `${c(RED, '  ✗')} ${c(BOLD, name)}${c(RED, ' [STALE missingInRN]')}${c(
+        DIM,
+        `  — ${name} exists in React Native Firebase but is still listed under missingInRN in config.ts; remove it or reclassify (e.g. differentShape) if types still differ.`,
+      )}`,
+    );
+  }
+
+  for (const name of result.staleConfigExtra) {
+    console.log(
+      `${c(RED, '  ✗')} ${c(BOLD, name)}${c(RED, ' [STALE extraInRN]')}${c(
+        DIM,
+        `  — ${name} is no longer an extra export in React Native Firebase but is still listed under extraInRN; remove from config.ts.`,
+      )}`,
+    );
+  }
+
+  for (const name of result.staleConfigDifferentShape) {
+    console.log(
+      `${c(RED, '  ✗')} ${c(BOLD, name)}${c(RED, ' [STALE differentShape]')}${c(
+        DIM,
+        `  — ${name} now matches the firebase-js-sdk shape; remove from differentShape in config.ts.`,
+      )}`,
+    );
+  }
+
+  return totalStale;
+}
+
 // ---------------------------------------------------------------------------
 // Public API
 // ---------------------------------------------------------------------------
 
 /**
  * Print a human-readable report to stdout.
  *
- * @returns `true` if there are any undocumented differences (CI failure).
+ * @returns `true` if there are undocumented differences or stale registry
+ *          entries (CI failure).
  */
 export function printReport(results: ComparisonResult[]): boolean {
   console.log(
@@ -72,11 +129,22 @@ export function printReport(results: ComparisonResult[]): boolean {
       result.extra.length +
       result.differentShape.length;
 
-    if (totalDiffs === 0) {
+    const totalStale = countStale(result);
+
+    if (totalDiffs === 0 && totalStale === 0) {
       console.log(c(GREEN, '  ✓ No differences found'));
       continue;
     }
 
+    if (totalDiffs === 0 && totalStale > 0) {
+      console.log(
+        c(
+          GREEN,
+          '  ✓ Exported types match the firebase-js-sdk snapshot (no live diffs)',
+        ),
+      );
+    }
+
     // --- Missing ---
     if (result.missing.length > 0) {
       printSection(
@@ -117,42 +185,27 @@ export function printReport(results: ComparisonResult[]): boolean {
       );
     }
 
-    // --- Stale config entries ---
-    const totalStale =
-      result.staleConfigMissing.length +
-      result.staleConfigExtra.length +
-      result.staleConfigDifferentShape.length;
-
-    if (totalStale > 0) {
-      const staleNames = [
-        ...result.staleConfigMissing,
-        ...result.staleConfigExtra,
-        ...result.staleConfigDifferentShape,
-      ];
-      console.log(`\n  ${c(RED, `Stale config entries`)} (${totalStale}):`);
-      for (const name of staleNames) {
-        console.log(
-          `${c(RED, '  ✗')} ${c(BOLD, name)}${c(RED, ' [STALE]')}${c(DIM, '  — now matches the firebase-js-sdk; remove from config.ts')}`,
-        );
-      }
-    }
+    const printedStale = printStaleRegistrySection(result);
 
     // --- Summary ---
     const totalUndoc =
       result.undocumentedMissing.length +
       result.undocumentedExtra.length +
       result.undocumentedDifferentShape.length;
 
-    if (totalUndoc > 0 || totalStale > 0) {
+    if (totalUndoc > 0 || printedStale > 0) {
       hasFailures = true;
       if (totalUndoc > 0) {
         console.log(
           `\n  ${c(RED, `✗ ${totalUndoc} undocumented difference(s) — add them to config.ts with a reason`)}`,
         );
       }
-      if (totalStale > 0) {
+      if (printedStale > 0) {
         console.log(
-          `\n  ${c(RED, `✗ ${totalStale} stale config entry/entries — remove them from config.ts`)}`,
+          `\n  ${c(
+            RED,
+            `✗ ${printedStale} stale registry entry/entries — update packages/<name>/config.ts for the type comparison tool`,
+          )}`,
         );
       }
     } else {