chore(messaging): deprecation warnings for v8 API ahead of future major release#8588
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MichaelVerdon
approved these changes
Jun 25, 2025
mikehardy
force-pushed
the
messaging-deprecations
branch
from
5612242 to
7f10685
Compare
mikehardy
approved these changes
Jul 1, 2025
mikehardy
left a comment
mikehardy
left a comment
Collaborator
There was a problem hiding this comment.
For me anyway, those native methods on this specific module are probably 90% of the reason anyone would ever use react-native-firebase vs firebase-js-sdk in the first place - native messaging API binding from firebase to device is a huge part of the value proposition of the whole package. I scanned the list and I think I'd leave them all 🤷
rebased to main, squashed to single commit, pending clean CI, let's go 🚂
mikehardy
changed the title
mikehardy
force-pushed
the
messaging-deprecations
branch
from
7f10685 to
fb681f2
Compare
mikehardy
force-pushed
the
messaging-deprecations
branch
from
fb681f2 to
8c34fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are a lot of messaging helper methods that are out of scope from all other Firebase SDKs (JS messaging has only 5, RNFB messaging has 31). I wonder if they should remain or should some be deprecated & removed during next major release. You can see them all listed here:
messaging-deprecations?expand=1#diff-312fbb9acaRelated issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter