fix: lint and remove close fix (to be done in a separate pr)

Author: cavramoniu-ionos

main.go

@@ -149,11 +149,9 @@ func main() {
 		// The returned closer tears down the private catalog connection; the
 		// server is a process-lifetime singleton, so we intentionally leave it
 		// open until the process exits.
-		d, err := dynamic.Register(ctx, server, products)
-		if err != nil {
+		if _, err := dynamic.Register(ctx, server, products); err != nil {
 			log.Fatalf("dynamic load mode: %v", err)
 		}
-		defer d.Close()
 
 	case LoadModeLazy:
 		// Small products register eagerly; Compute and Object Storage defer

tools/dynamic/catalog.go

@@ -34,7 +34,6 @@ func buildCatalog(ctx context.Context, products []Product) (*dispatcher, error)
 	client := mcp.NewClient(&mcp.Implementation{Name: "ionos-cloud-mcp-catalog-reader", Version: "internal"}, nil)
 	session, err := client.Connect(ctx, clientT, nil)
 	if err != nil {
-		_ = srvSession.Close()
 		return nil, fmt.Errorf("dynamic: connecting catalog reader: %w", err)
 	}
 
@@ -51,17 +50,14 @@ func buildCatalog(ctx context.Context, products []Product) (*dispatcher, error)
 		// Attribution + dedup: register on a throwaway server and read it back.
 		tools, err := productTools(ctx, p)
 		if err != nil {
-			_ = d.Close()
 			return nil, err
 		}
 		for _, tool := range tools {
 			if prev, dup := d.byName[tool.Name]; dup {
-				_ = d.Close()
 				return nil, fmt.Errorf("dynamic: duplicate tool name %q registered by products %q and %q", tool.Name, prev.Group, p.Name)
 			}
 			schema, mErr := json.Marshal(tool.InputSchema)
 			if mErr != nil {
-				_ = d.Close()
 				return nil, fmt.Errorf("dynamic: marshaling input schema for %q: %w", tool.Name, mErr)
 			}
 			e := catalogEntry{
@@ -77,7 +73,6 @@ func buildCatalog(ctx context.Context, products []Product) (*dispatcher, error)
 	}
 
 	if len(d.entries) == 0 {
-		_ = d.Close()
 		return nil, fmt.Errorf("dynamic: catalog is empty (no products registered any tools)")
 	}
 

tools/inputs.go

@@ -366,22 +366,3 @@ type CallToolInput struct {
 	Name      string         `json:"name" jsonschema:"the exact name of the tool to invoke (from ionos_search_tools)"`
 	Arguments map[string]any `json:"arguments,omitempty" jsonschema:"the tool's arguments as a JSON object; see ionos_describe_tools for the schema"`
 }
-
-// Dynamic load-mode meta-tool input types. Used only when the server runs in
-// 'dynamic' mode, where these are the only tools the client sees and the full
-// product catalog is browsed/invoked through them.
-
-type SearchToolsInput struct {
-	Query string  `json:"query" jsonschema:"keywords to match against tool names and descriptions; leave empty to browse, optionally with group"`
-	Group *string `json:"group,omitempty" jsonschema:"restrict results to a single product group (e.g. compute, dns, billing, cert, activitylog, objectstorage, k8s)"`
-	Limit *int    `json:"limit,omitempty" jsonschema:"maximum number of results to return; omit for the default of 10, or pass 0 for no limit. Must not be negative."`
-}
-
-type DescribeToolsInput struct {
-	Names []string `json:"names" jsonschema:"the exact names of the tools to describe; returns each tool's description and full JSON input schema"`
-}
-
-type CallToolInput struct {
-	Name      string         `json:"name" jsonschema:"the exact name of the tool to invoke (from ionos_search_tools)"`
-	Arguments map[string]any `json:"arguments,omitempty" jsonschema:"the tool's arguments as a JSON object; see ionos_describe_tools for the schema"`
-}