Skip to content

Commit 500feef

Browse files
authored
feat: add spell-check to check job (#105)
Adds an optional `spell-check` step to the `check` job. Adds a `build` job that ensures the `node_modules` cache is present for other steps. Makes all `test-*` jobs depend on `build` instead of `check` so they can run in parallel.
1 parent 5d94545 commit 500feef

File tree

1 file changed

+28
-17
lines changed

1 file changed

+28
-17
lines changed

.github/workflows/js-test-and-release.yml

Lines changed: 28 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,31 @@ defaults:
2828

2929
jobs:
3030

31+
build:
32+
runs-on: ubuntu-latest
33+
steps:
34+
- uses: actions/checkout@v4
35+
- uses: actions/setup-node@v4
36+
with:
37+
node-version: lts/*
38+
- uses: ipfs/aegir/actions/cache-node-modules@main
39+
3140
check:
41+
needs: build
3242
runs-on: ubuntu-latest
3343
steps:
34-
- uses: actions/checkout@v4
35-
- uses: actions/setup-node@v4
36-
with:
37-
node-version: lts/*
38-
- uses: ipfs/aegir/actions/cache-node-modules@main
39-
- run: npm run --if-present lint
40-
- run: npm run --if-present dep-check
41-
- run: npm run --if-present doc-check
44+
- uses: actions/checkout@v4
45+
- uses: actions/setup-node@v4
46+
with:
47+
node-version: lts/*
48+
- uses: ipfs/aegir/actions/cache-node-modules@main
49+
- run: npm run --if-present lint
50+
- run: npm run --if-present dep-check
51+
- run: npm run --if-present doc-check
52+
- run: npm run --if-present spell-check
4253

4354
test-node:
44-
needs: check
55+
needs: build
4556
runs-on: ${{ matrix.os }}
4657
strategy:
4758
matrix:
@@ -63,7 +74,7 @@ jobs:
6374
fail_ci_if_error: false
6475

6576
test-chrome:
66-
needs: check
77+
needs: build
6778
runs-on: ubuntu-latest
6879
steps:
6980
- uses: actions/checkout@v4
@@ -80,7 +91,7 @@ jobs:
8091
fail_ci_if_error: false
8192

8293
test-chrome-webworker:
83-
needs: check
94+
needs: build
8495
runs-on: ubuntu-latest
8596
steps:
8697
- uses: actions/checkout@v4
@@ -97,7 +108,7 @@ jobs:
97108
fail_ci_if_error: false
98109

99110
test-firefox:
100-
needs: check
111+
needs: build
101112
runs-on: ubuntu-latest
102113
steps:
103114
- uses: actions/checkout@v4
@@ -114,7 +125,7 @@ jobs:
114125
fail_ci_if_error: false
115126

116127
test-firefox-webworker:
117-
needs: check
128+
needs: build
118129
runs-on: ubuntu-latest
119130
steps:
120131
- uses: actions/checkout@v4
@@ -131,7 +142,7 @@ jobs:
131142
fail_ci_if_error: false
132143

133144
test-webkit:
134-
needs: check
145+
needs: build
135146
runs-on: ${{ matrix.os }}
136147
strategy:
137148
matrix:
@@ -154,7 +165,7 @@ jobs:
154165
fail_ci_if_error: false
155166

156167
test-webkit-webworker:
157-
needs: check
168+
needs: build
158169
runs-on: ${{ matrix.os }}
159170
strategy:
160171
matrix:
@@ -177,7 +188,7 @@ jobs:
177188
fail_ci_if_error: false
178189

179190
test-electron-main:
180-
needs: check
191+
needs: build
181192
runs-on: ubuntu-latest
182193
steps:
183194
- uses: actions/checkout@v4
@@ -194,7 +205,7 @@ jobs:
194205
fail_ci_if_error: false
195206

196207
test-electron-renderer:
197-
needs: check
208+
needs: build
198209
runs-on: ubuntu-latest
199210
steps:
200211
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)