Skip to content

Commit c26bfe3

Browse files
authored
Remove redundant VirtualIP test case (#1336)
1 parent dbb3880 commit c26bfe3

1 file changed

Lines changed: 0 additions & 32 deletions

File tree

internal/controllers/networking/networkinterface_ephemeralvirtualip_controller_test.go

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -240,36 +240,4 @@ var _ = Describe("NetworkInterfaceEphemeralVirtualIP", func() {
240240
By("waiting for the undesired virtual IP to be gone")
241241
Eventually(Get(undesiredVip)).Should(Satisfy(apierrors.IsNotFound))
242242
})
243-
244-
It("should not delete externally managed virtual IPs for a network interface", func(ctx SpecContext) {
245-
By("creating a network interface")
246-
nic := &networkingv1alpha1.NetworkInterface{
247-
ObjectMeta: metav1.ObjectMeta{
248-
Namespace: ns.Name,
249-
GenerateName: "nic-",
250-
},
251-
Spec: networkingv1alpha1.NetworkInterfaceSpec{
252-
NetworkRef: corev1.LocalObjectReference{Name: "my-network"},
253-
IPs: []networkingv1alpha1.IPSource{{Value: commonv1alpha1.MustParseNewIP("10.0.0.1")}},
254-
},
255-
}
256-
Expect(k8sClient.Create(ctx, nic)).To(Succeed())
257-
258-
By("creating an undesired virtual IP")
259-
externalVip := &networkingv1alpha1.VirtualIP{
260-
ObjectMeta: metav1.ObjectMeta{
261-
Namespace: ns.Name,
262-
GenerateName: "external-vip-",
263-
},
264-
Spec: networkingv1alpha1.VirtualIPSpec{
265-
Type: networkingv1alpha1.VirtualIPTypePublic,
266-
IPFamily: corev1.IPv4Protocol,
267-
},
268-
}
269-
Expect(ctrl.SetControllerReference(nic, externalVip, k8sClient.Scheme())).To(Succeed())
270-
Expect(k8sClient.Create(ctx, externalVip)).To(Succeed())
271-
272-
By("asserting that the virtual IP is not being deleted")
273-
Eventually(Object(externalVip)).Should(HaveField("DeletionTimestamp", BeNil()))
274-
})
275243
})

0 commit comments

Comments
 (0)