Controller adds GPU PCI addresses to domain XML

Author: friegger

internal/controllers/machine_controller.go

@@ -601,6 +601,8 @@ func (r *MachineReconciler) domainFor(
 		serialTargetType = "pci-serial"
 	}
 
+	hostDevs := clamedGPUsToHostDevs(machine)
+
 	domainDesc := &libvirtxml.Domain{
 		Name:       machine.GetID(),
 		UUID:       machine.GetID(),
@@ -681,6 +683,7 @@ func (r *MachineReconciler) domainFor(
 					},
 				},
 			},
+			Hostdevs: hostDevs,
 		},
 	}
 

internal/controllers/machine_controller_gpus.go

@@ -0,0 +1,44 @@
+// SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and IronCore contributors
+// SPDX-License-Identifier: Apache-2.0
+
+package controllers
+
+import (
+	"fmt"
+
+	"github.com/ironcore-dev/libvirt-provider/api"
+	"libvirt.org/go/libvirtxml"
+)
+
+func clamedGPUsToHostDevs(machine *api.Machine) []libvirtxml.DomainHostdev {
+	hostDevs := make([]libvirtxml.DomainHostdev, len(machine.Spec.Gpu))
+
+	for i, gpuAddr := range machine.Spec.Gpu {
+		domain := gpuAddr.Domain
+		bus := gpuAddr.Bus
+		slot := gpuAddr.Slot
+		function := gpuAddr.Function
+
+		hostDevs[i] = libvirtxml.DomainHostdev{
+			Alias: &libvirtxml.DomainAlias{
+				Name: fmt.Sprintf("gpu%d", i),
+			},
+			Managed: "yes",
+			SubsysPCI: &libvirtxml.DomainHostdevSubsysPCI{
+				Source: &libvirtxml.DomainHostdevSubsysPCISource{
+					Address: &libvirtxml.DomainAddressPCI{
+						Domain:   &domain,
+						Bus:      &bus,
+						Slot:     &slot,
+						Function: &function,
+					},
+				},
+			},
+			Address: &libvirtxml.DomainAddress{
+				PCI: &libvirtxml.DomainAddressPCI{},
+			},
+		}
+	}
+
+	return hostDevs
+}

internal/controllers/machine_controller_gpus_test.go

@@ -0,0 +1,100 @@
+// SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and IronCore contributors
+// SPDX-License-Identifier: Apache-2.0
+
+package controllers
+
+import (
+	"github.com/ironcore-dev/libvirt-provider/api"
+	"github.com/ironcore-dev/provider-utils/claimutils/pci"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	"libvirt.org/go/libvirtxml"
+)
+
+var _ = Describe("MachineController with GPUs", func() {
+	It("should convert claimed GPUs to libvirt host devices", func(ctx SpecContext) {
+		By("creating a machine with claimed GPUs")
+		machine := &api.Machine{
+			Spec: api.MachineSpec{
+				Gpu: []pci.Address{
+					{Domain: 0, Bus: 1, Slot: 0, Function: 0},
+					{Domain: 0, Bus: 2, Slot: 0, Function: 1},
+				},
+			},
+		}
+
+		By("converting claimed GPUs to host devices")
+		hostDevs := clamedGPUsToHostDevs(machine)
+
+		By("ensuring the correct host devices are returned")
+		Expect(hostDevs).To(HaveLen(2))
+		Expect(hostDevs).To(ContainElements(
+			libvirtxml.DomainHostdev{
+				Alias: &libvirtxml.DomainAlias{
+					Name: "gpu0",
+				},
+				Managed: "yes",
+				SubsysPCI: &libvirtxml.DomainHostdevSubsysPCI{
+					Source: &libvirtxml.DomainHostdevSubsysPCISource{
+						Address: &libvirtxml.DomainAddressPCI{
+							Domain:   &machine.Spec.Gpu[0].Domain,
+							Bus:      &machine.Spec.Gpu[0].Bus,
+							Slot:     &machine.Spec.Gpu[0].Slot,
+							Function: &machine.Spec.Gpu[0].Function,
+						},
+					},
+				},
+				Address: &libvirtxml.DomainAddress{
+					PCI: &libvirtxml.DomainAddressPCI{},
+				},
+			},
+			libvirtxml.DomainHostdev{
+				Alias: &libvirtxml.DomainAlias{
+					Name: "gpu1",
+				},
+				Managed: "yes",
+				SubsysPCI: &libvirtxml.DomainHostdevSubsysPCI{
+					Source: &libvirtxml.DomainHostdevSubsysPCISource{
+						Address: &libvirtxml.DomainAddressPCI{
+							Domain:   &machine.Spec.Gpu[1].Domain,
+							Bus:      &machine.Spec.Gpu[1].Bus,
+							Slot:     &machine.Spec.Gpu[1].Slot,
+							Function: &machine.Spec.Gpu[1].Function,
+						},
+					},
+				},
+				Address: &libvirtxml.DomainAddress{
+					PCI: &libvirtxml.DomainAddressPCI{},
+				},
+			},
+		))
+	})
+
+	It("should convert claimed GPUs to libvirt host devices", func(ctx SpecContext) {
+		By("creating a machine with 0 claimed GPUs")
+		machine := &api.Machine{
+			Spec: api.MachineSpec{
+				Gpu: []pci.Address{},
+			},
+		}
+
+		By("converting claimed GPUs to host devices")
+		hostDevs := clamedGPUsToHostDevs(machine)
+
+		By("ensuring no host devices are returned")
+		Expect(hostDevs).To(HaveLen(0))
+	})
+
+	It("should convert claimed GPUs to libvirt host devices", func(ctx SpecContext) {
+		By("creating a machine with nil Gu field")
+		machine := &api.Machine{
+			Spec: api.MachineSpec{},
+		}
+
+		By("converting claimed GPUs to host devices")
+		hostDevs := clamedGPUsToHostDevs(machine)
+
+		By("ensuring no host devices are returned")
+		Expect(hostDevs).To(HaveLen(0))
+	})
+})