Apply review comment

Author: jonathanarnault

packages/e2e/src/authors.spec.ts

@@ -1,7 +1,7 @@
 import { expect, test } from "@playwright/test";
 import { launchViewer, uploadFile } from "./support/upload";
 
-test("document authors section", async ({ page }) => {
+test("authors section", async ({ page }) => {
 	await page.goto("/");
 
 	await uploadFile(page, "document.tei");

packages/react-tei/src/authors/tags/Address.tsx

@@ -2,10 +2,10 @@ import { Typography } from "@mui/material";
 import { DebugTag } from "../../debug/DebugTag";
 import type { ComponentProps } from "../../tags/type";
 import { Value } from "../../tags/Value";
-import { useValueSeparator } from "./useValueSeparator";
+import { useJoinValues } from "./useJoinValues";
 
 export function Address({ data }: ComponentProps) {
-	const value = useValueSeparator(data.value, ", ");
+	const value = useJoinValues(data.value, ", ");
 
 	if (!value.length) {
 		return (

packages/react-tei/src/authors/tags/Affiliation.tsx

@@ -4,11 +4,11 @@ import { useId } from "react";
 import { DebugTag } from "../../debug/DebugTag";
 import type { ComponentProps } from "../../tags/type";
 import { Value } from "../../tags/Value";
-import { useValueSeparator } from "./useValueSeparator";
+import { useJoinValues } from "./useJoinValues";
 
 export function Affiliation({ data }: ComponentProps) {
 	const id = useId();
-	const value = useValueSeparator(data.value, ", ");
+	const value = useJoinValues(data.value, ", ");
 
 	if (!value.length) {
 		return (

packages/react-tei/src/authors/tags/Author.tsx

@@ -7,7 +7,7 @@ import { IS_DEBUG } from "../../debug/debug.const";
 import type { DocumentJson } from "../../parser/document";
 import type { ComponentProps } from "../../tags/type";
 import { Value } from "../../tags/Value";
-import { useValueSeparator } from "./useValueSeparator";
+import { useJoinValues } from "./useJoinValues";
 
 const AFFILIATION_TAG = "affiliation";
 
@@ -29,7 +29,7 @@ export function Author({ data }: ComponentProps) {
 		return valueArray.filter((item) => item.tag !== AFFILIATION_TAG);
 	}, [data.attributes, valueArray]);
 
-	const nameWithSpacing = useValueSeparator(name, " ");
+	const nameWithSpacing = useJoinValues(name, " ");
 
 	const affiliations = useMemo(() => {
 		return valueArray.filter((item) => item.tag === AFFILIATION_TAG);

…/authors/tags/useValueSeparator.spec.tsx …/src/authors/tags/useJoinValues.spec.tsxpackages/react-tei/src/authors/tags/useValueSeparator.spec.tsx renamed to packages/react-tei/src/authors/tags/useJoinValues.spec.tsx packages/react-tei/src/authors/tags/useValueSeparator.spec.tsx renamed to packages/react-tei/src/authors/tags/useJoinValues.spec.tsx

@@ -1,11 +1,11 @@
 import { describe, expect, it } from "vitest";
 import { renderHook } from "vitest-browser-react";
-import { useValueSeparator } from "./useValueSeparator";
+import { useJoinValues } from "./useJoinValues";
 
-describe("useValueSeparator", () => {
+describe("useJoinValues", () => {
 	it("should add text tags with separator between values", async () => {
 		const { result } = await renderHook(() =>
-			useValueSeparator(
+			useJoinValues(
 				[
 					{ tag: "orgName", value: [{ tag: "#text", value: "University A" }] },
 					{ tag: "orgName", value: [{ tag: "#text", value: "Institute B" }] },

…i/src/authors/tags/useValueSeparator.tsx …t-tei/src/authors/tags/useJoinValues.tsxpackages/react-tei/src/authors/tags/useValueSeparator.tsx renamed to packages/react-tei/src/authors/tags/useJoinValues.tsx packages/react-tei/src/authors/tags/useValueSeparator.tsx renamed to packages/react-tei/src/authors/tags/useJoinValues.tsx

@@ -1,7 +1,7 @@
 import { useMemo } from "react";
 import type { DocumentJsonValue } from "../../parser/document";
 
-export function useValueSeparator(value: DocumentJsonValue, separator: string) {
+export function useJoinValues(value: DocumentJsonValue, separator: string) {
 	return useMemo(() => {
 		if (!Array.isArray(value)) {
 			return [];