nest term of the same group

Author: ThieryMichel

packages/react-tei/src/termEnrichment/computeEnrichedTerms.spec.ts

@@ -260,7 +260,7 @@ describe("computeEnrichedTerms", () => {
 		]);
 	});
 
-	it("should not nest terms that are in the same group", () => {
+	it("should nest terms that are in the same group", () => {
 		const termByGroup = {
 			group1: [
 				{ term: "cat lover", displayed: true },
@@ -271,7 +271,22 @@ describe("computeEnrichedTerms", () => {
 		const terms = computeEnrichedTerms(termByGroup);
 
 		expect(terms).toEqual([
-			{ term: "cat lover", groups: ["group1"] },
+			{
+				term: "cat lover",
+				groups: ["group1"],
+				subTerms: [
+					{
+						groups: ["group1"],
+						term: "cat",
+					},
+					{
+						artificial: true,
+						groups: ["group1"],
+						sourceTerm: "cat lover",
+						term: " lover",
+					},
+				],
+			},
 			{ term: "cat", groups: ["group1"] },
 		]);
 	});

packages/react-tei/src/termEnrichment/nestContainedTerms.spec.ts

@@ -39,18 +39,6 @@ describe("nestContainedTerms", () => {
 			expect(isContainedIn(longerTerm, shorterTerm)).toBe(true);
 		});
 
-		it("should return false when longerTerm contain shorter one but they are of the same group", () => {
-			const longerTerm = {
-				term: "cat lover",
-				groups: ["group1"],
-			};
-			const shorterTerm = {
-				term: "cat",
-				groups: ["group1"],
-			};
-			expect(isContainedIn(longerTerm, shorterTerm)).toBe(false);
-		});
-
 		it('should return false when longerTerm contain shorter one but shorter is not a full word (e.g., "conf" in "overconfident")', () => {
 			const longerTerm = {
 				term: "overconfident",

packages/react-tei/src/termEnrichment/nestContainedTerms.ts

@@ -7,9 +7,6 @@ export const isContainedIn = (
 	longer: GroupedTerm,
 	shorter: GroupedTerm,
 ): boolean => {
-	if (shorter.groups.every((g) => longer.groups.includes(g))) {
-		return false;
-	}
 	if (shorter.term === longer.term) return false;
 
 	const shorterWordRegex = new RegExp(