test: add unit tests for log file download error scenarios and controller logic

Author: ChernyavckiiPavlo

src/main/java/com/itasocialacademy/oitassist/logfile/exceptions/LogFileNotFoundException.java

@@ -5,6 +5,6 @@
 
 public class LogFileNotFoundException extends NotFoundException {
     public LogFileNotFoundException(String fileName) {
-        super("Log file not found" + fileName, ErrorCode.LOG_FILE_NOT_FOUND);
+        super("Log file not found " + fileName, ErrorCode.LOG_FILE_NOT_FOUND);
     }
 }

src/test/java/com/itasocialacademy/oitassist/logfile/controller/LogFileControllerTest.java

@@ -1,21 +1,25 @@
 package com.itasocialacademy.oitassist.logfile.controller;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.hamcrest.Matchers.containsString;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoInteractions;
 import static org.mockito.Mockito.when;
+import static org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors.user;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
 
 import com.itasocialacademy.oitassist.core.web.AppExceptionHttpStatusMapper;
 import com.itasocialacademy.oitassist.logfile.api.LogFileResponse;
 import com.itasocialacademy.oitassist.logfile.api.PageResponse;
+import com.itasocialacademy.oitassist.logfile.dao.model.LogFileDownloadResult;
+import com.itasocialacademy.oitassist.logfile.exceptions.InvalidLogFileNameException;
+import com.itasocialacademy.oitassist.logfile.exceptions.LogFileNotFoundException;
 import com.itasocialacademy.oitassist.logfile.service.LogFileService;
 import com.itasocialacademy.oitassist.security.jwt.JwtFilter;
+import java.nio.charset.StandardCharsets;
 import java.time.Instant;
 import java.util.List;
 import org.junit.jupiter.api.Test;
@@ -28,8 +32,10 @@
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.FilterType;
 import org.springframework.context.annotation.Import;
+import org.springframework.core.io.ByteArrayResource;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.domain.Sort;
+import org.springframework.http.HttpHeaders;
 import org.springframework.http.MediaType;
 import org.springframework.security.config.annotation.method.configuration.EnableMethodSecurity;
 import org.springframework.security.config.annotation.web.builders.HttpSecurity;
@@ -45,7 +51,10 @@
     excludeFilters = @ComponentScan.Filter(
         type = FilterType.ASSIGNABLE_TYPE,
         classes = JwtFilter.class))
-@Import(LogFileControllerTest.SecurityTestConfiguration.class)
+@Import({
+    LogFileControllerTest.SecurityTestConfiguration.class,
+    AppExceptionHttpStatusMapper.class
+})
 class LogFileControllerTest {
 
     private static final String ENDPOINT =
@@ -62,9 +71,6 @@ class LogFileControllerTest {
     @MockitoBean
     private LogFileService logFileService;
 
-    @MockitoBean
-    private AppExceptionHttpStatusMapper appExceptionHttpStatusMapper;
-
     @Test
     void shouldLoadControllerThroughMethodSecurityProxy() {
         assertThat(AopUtils.isAopProxy(logFileController))
@@ -476,4 +482,90 @@ void shouldReturnBadRequestWhenSearchNameIsMissing()
 
         verifyNoInteractions(logFileService);
     }
+
+    @Test
+    void shouldDownloadLogFile() throws Exception {
+        byte[] fileContent =
+            "test log content"
+                .getBytes(StandardCharsets.UTF_8);
+
+        LogFileDownloadResult downloadResult =
+            new LogFileDownloadResult(
+                "app.log",
+                new ByteArrayResource(fileContent));
+
+        when(logFileService.downloadFile("app.log"))
+            .thenReturn(downloadResult);
+
+        mockMvc.perform(
+            get("/api/v1/admin/log-files/app.log/download")
+                .with(
+                    user("admin")
+                        .roles("ADMIN")))
+            .andExpect(status().isOk())
+            .andExpect(
+                content().contentType(
+                    MediaType.APPLICATION_OCTET_STREAM))
+            .andExpect(
+                header().string(
+                    HttpHeaders.CONTENT_DISPOSITION,
+                    containsString("attachment")))
+            .andExpect(
+                header().string(
+                    HttpHeaders.CONTENT_DISPOSITION,
+                    containsString("app.log")))
+            .andExpect(
+                content().bytes(fileContent));
+
+        verify(logFileService)
+            .downloadFile("app.log");
+    }
+
+    @Test
+    void shouldReturnBadRequestForInvalidDownloadFileName()
+        throws Exception {
+
+        when(logFileService.downloadFile("app..log"))
+            .thenThrow(
+                new InvalidLogFileNameException());
+
+        mockMvc.perform(
+            get("/api/v1/admin/log-files/app..log/download")
+                .with(
+                    user("admin")
+                        .roles("ADMIN")))
+            .andExpect(
+                status().isBadRequest())
+            .andExpect(
+                jsonPath("$.code")
+                    .value("INVALID_LOG_FILE_NAME"));
+
+        verify(logFileService)
+            .downloadFile("app..log");
+    }
+
+    @Test
+    void shouldReturnNotFoundWhenDownloadFileDoesNotExist()
+        throws Exception {
+
+        when(logFileService.downloadFile("missing.log"))
+            .thenThrow(
+                new LogFileNotFoundException(
+                    "missing.log"));
+
+        mockMvc.perform(
+            get("/api/v1/admin/log-files/missing.log/download")
+                .with(
+                    user("admin")
+                        .roles("ADMIN")))
+            .andExpect(
+                status().isNotFound())
+            .andExpect(
+                jsonPath("$.code")
+                    .value("LOG_FILE_NOT_FOUND"));
+
+        verify(logFileService)
+            .downloadFile("missing.log");
+    }
+
 }

src/test/java/com/itasocialacademy/oitassist/logfile/dao/FileSystemLogFileDaoTest.java

@@ -237,7 +237,7 @@ void shouldExcludeDirectoriesMatchingSearchName()
     }
 
     @Test
-    void shouldThrowLogFileListingExceptionWhenDirectoryListingFails(){
+    void shouldThrowLogFileListingExceptionWhenDirectoryListingFails() {
 
         Path logDirectory = tempDirectory;
         String configuredLogFile =
@@ -269,7 +269,7 @@ void shouldThrowLogFileListingExceptionWhenDirectoryListingFails(){
     }
 
     @Test
-    void shouldThrowLogFileListingExceptionWhenReadingMetadataFails(){
+    void shouldThrowLogFileListingExceptionWhenReadingMetadataFails() {
 
         Path logDirectory = tempDirectory;
         Path logFile = logDirectory.resolve("app.log");
@@ -308,7 +308,7 @@ void shouldThrowLogFileListingExceptionWhenReadingMetadataFails(){
     }
 
     @Test
-    void shouldSkipFileWhenItDisappearsDuringDirectoryScan(){
+    void shouldSkipFileWhenItDisappearsDuringDirectoryScan() {
 
         Path logDirectory = tempDirectory;
         Path logFile = logDirectory.resolve("app.log");
@@ -427,7 +427,7 @@ void shouldReturnEmptyWhenDownloadPathIsDirectory()
     }
 
     @Test
-    void shouldReturnEmptyWhenDownloadFileIsSymbolicLink(){
+    void shouldReturnEmptyWhenDownloadFileIsSymbolicLink() {
 
         Path filePath =
             tempDirectory

src/test/java/com/itasocialacademy/oitassist/logfile/service/LogFileServiceImplTest.java

@@ -51,7 +51,6 @@ class LogFileServiceImplTest {
     @TempDir
     Path tempDirectory;
 
-
     private LogFileServiceImpl logFileService;
 
     @BeforeEach
@@ -510,7 +509,7 @@ void shouldReturnDownloadResultForValidFileName()
             .isNotNull();
 
         try (InputStream inputStream =
-                 result.resource().getInputStream()) {
+            result.resource().getInputStream()) {
 
             String content =
                 new String(