Skip to content

Commit 254f139

Browse files
committed
revert FE to port 80
This makes testing containerization easier
1 parent 8433833 commit 254f139

4 files changed

Lines changed: 6 additions & 10 deletions

File tree

SETUP.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,12 @@ Run the frontend.
2222

2323
```sh
2424
npm i
25-
cd apps/frontend && npm run dev
25+
cd apps/frontend && sudo npm run dev
2626
```
2727

28-
if you want to hack on the telegram login flow, you'll need to proxy port 80 to the development port
28+
The reason we're running sudo here is because the Telegram login widget needs access to port 80 to work. This is definitely not ideal and something we should fix so contributors don't need to run sudo.
2929

30-
```sh
31-
brew install socat
32-
sudo socat TCP-LISTEN:80,fork TCP:localhost:8080
33-
```
34-
`sudo` is needed to access port 80.
30+
`sudo` is only needed to access port 80.
3531

3632
Navigate to [127.0.0.1](http://127.0.0.1/)
3733

apps/frontend/src/pages/NewCustomGroup/components/TelegramBotSetup.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const TelegramBotSetup = () => {
1818

1919
return (
2020
<>
21-
{/* In local dev, you need to set bot's domain to 127.0.0.1:80 for FE button to work
21+
{/* In local dev, you need to set bot's domain to 127.0.0.1 for FE button to work
2222
But the backend validation will fail if the bot's domain is not the same as the one set in the backend
2323
*/}
2424
{!telegramIdentity && <TelegramLogin />}

apps/frontend/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default defineConfig(({ mode }) => {
2424
},
2525
server: {
2626
host: "127.0.0.1",
27-
port: 8080,
27+
port: 80,
2828
proxy: {
2929
"/api": {
3030
target: env.VITE_LOCAL_BACKEND_URL,

docker-compose.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ services:
2929
- "3000:3000"
3030
environment:
3131
- MODE=development
32-
- LOCAL_URL=http:/127.0.0.1
32+
- LOCAL_URL=http://127.0.0.1
3333
- PORT_FORWARDING_ADDRESS
3434
## Alchemy
3535
- ALCHEMY_API_KEY

0 commit comments

Comments
 (0)