Skip to content

Commit 6509512

Browse files
authored
Merge pull request #158 from jakeberv/codex/cran-resubmission-vignette-links
Fix quick-start vignette links for CRAN resubmission
2 parents 110824b + 91e2d45 commit 6509512

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

cran-comments.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
11
## Resubmission
22

3-
This is a new submission of **bifrost 0.1.4**. The current CRAN version is **bifrost 0.1.3**.
3+
This is a resubmission of **bifrost 0.1.4** following CRAN feedback.
44

5-
### Changes since 0.1.3
5+
### Changes made in response to CRAN comments
66

7-
- Added a new package vignette, **"Quick Start with bifrost"**, with a minimal end-to-end simulated example.
8-
- Clarified `searchOptimalConfiguration()` documentation around tree input requirements, recommended `mvgls()` methods, and the role of `error = TRUE`.
9-
- Reworked the README to foreground installation, documentation, and citation guidance.
10-
- Added two pkgdown-only background articles on multivariate Brownian motion / shifts and whole-tree PCA / model-selection issues. These articles are excluded from the CRAN tarball via `.Rbuildignore`.
11-
- Updated package authorship metadata and refreshed `citation("bifrost")` for the live bioRxiv preprint, the in-press application paper, and the foundational `mvMORPH` references.
12-
- Disabled a deprecated vignette-preview step in GitHub Actions CI. This does not affect package runtime or CRAN checks.
7+
- In the installed quick-start vignette, replaced relative links to pkgdown-only background articles with full website URLs. This removes invalid local file URIs from `inst/doc/quick-start-vignette.html`.
138

149
## Test environments
1510

vignettes/quick-start-vignette.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,4 +190,4 @@ When moving from this smoke test to a real dataset:
190190
- archive the tree, trait matrix, formula, thresholds, and random seed used for final fits,
191191
- repeat searches under nearby settings before treating individual inferred shifts as robust.
192192

193-
Once this smoke test runs cleanly, the next step is usually to move to a real dataset and inspect the returned shifts, IC support values, and regime-specific VCVs in more detail. For a full empirical workflow, continue to the [jaw-shape vignette](jaw-shape-vignette.html); for broader conceptual background, see [Brownian Motion and Multivariate Shifts](theoretical-background-vignette.html) and [Whole-Tree Models, PCA, and bifrost](pca-model-selection-and-bifrost-vignette.html).
193+
Once this smoke test runs cleanly, the next step is usually to move to a real dataset and inspect the returned shifts, IC support values, and regime-specific VCVs in more detail. For a full empirical workflow, continue to the [jaw-shape vignette](jaw-shape-vignette.html); for broader conceptual background on the package website, see [Brownian Motion and Multivariate Shifts](https://jakeberv.com/bifrost/articles/theoretical-background-vignette.html) and [Whole-Tree Models, PCA, and bifrost](https://jakeberv.com/bifrost/articles/pca-model-selection-and-bifrost-vignette.html).

0 commit comments

Comments
 (0)