Merge pull request #199 from appkit-framework/channel-state-checks

Throw exceptions for operations on closed or failed channel

Author: WyriHaximus

src/Channel.php

@@ -109,8 +109,20 @@ public function __construct(private Connection $connection, private Client $clie
         $this->bodyBuffer = new Buffer();
     }
 
-    public function getClient(): Connection
+    protected function getClient(): Connection
     {
+        if ($this->state === ChannelState::Error) {
+            throw new ChannelException('Channel in error state.');
+        }
+
+        if ($this->state === ChannelState::Closing) {
+            throw new ChannelException('Channel is closing');
+        }
+
+        if ($this->state === ChannelState::Closed) {
+            throw new ChannelException('Channel is closed');
+        }
+
         return $this->connection;
     }
 

test/ChannelTest.php

@@ -265,4 +265,18 @@ public function testChannelClosingMidMessageHandling(): void
 
         self::assertFalse($c->isConnected());
     }
+
+    public function testAttemptingToOperateOnANoLongerConnectedConnectionThrows(): void
+    {
+        self::expectException(ChannelException::class);
+        self::expectExceptionMessage('Channel is closed');
+
+        $c = $this->helper->createClient();
+
+        $ch = $c->connect()->channel();
+        self::assertTrue($c->isConnected());
+        $c->disconnect();
+        self::assertFalse($c->isConnected());
+        $ch->publish('hi', [], '', 'test_queue');
+    }
 }