fix(rust/sedona-functions): Fix scalar iteration with num_iterations > 1 (apache#1041)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: paleolimbot

c/sedona-geos/src/st_area.rs

@@ -57,7 +57,7 @@ impl SedonaScalarKernel for STArea {
         executor.execute_wkb_void(|maybe_wkb| {
             match maybe_wkb {
                 Some(wkb) => {
-                    builder.append_value(invoke_scalar(&wkb)?);
+                    builder.append_value(invoke_scalar(wkb)?);
                 }
                 _ => builder.append_null(),
             }

c/sedona-geos/src/st_boundary.rs

@@ -70,7 +70,7 @@ impl SedonaScalarKernel for STBoundary {
         executor.execute_wkb_void(|maybe_wkb| {
             match maybe_wkb {
                 Some(wkb) => {
-                    invoke_scalar(&wkb, &mut builder)?;
+                    invoke_scalar(wkb, &mut builder)?;
                     builder.append_value([]);
                 }
                 _ => builder.append_null(),

c/sedona-geos/src/st_buffer.rs

@@ -132,7 +132,7 @@ fn invoke_batch_impl(arg_types: &[SedonaType], args: &[ColumnarValue]) -> Result
                 if (is_left && distance < 0.0) || (is_right && distance > 0.0) {
                     distance = -distance;
                 }
-                invoke_scalar(&wkb, distance, &params, &mut builder)?;
+                invoke_scalar(wkb, distance, &params, &mut builder)?;
                 builder.append_value([]);
             }
             _ => builder.append_null(),

c/sedona-geos/src/st_buildarea.rs

@@ -64,7 +64,7 @@ impl SedonaScalarKernel for STBuildArea {
         executor.execute_wkb_void(|maybe_geom| {
             match maybe_geom {
                 Some(geom) => {
-                    if invoke_scalar(&geom, &mut builder)? {
+                    if invoke_scalar(geom, &mut builder)? {
                         builder.append_value([]);
                     } else {
                         builder.append_null();

c/sedona-geos/src/st_centroid.rs

@@ -61,7 +61,7 @@ impl SedonaScalarKernel for STCentroid {
         executor.execute_wkb_void(|maybe_wkb| {
             match maybe_wkb {
                 Some(wkb) => {
-                    invoke_scalar(&wkb, &mut builder)?;
+                    invoke_scalar(wkb, &mut builder)?;
                     builder.append_value([]);
                 }
                 _ => builder.append_null(),

c/sedona-geos/src/st_concavehull.rs

@@ -121,7 +121,7 @@ fn invoke_batch_impl(arg_types: &[SedonaType], args: &[ColumnarValue]) -> Result
             allow_holes_iter.next().unwrap(),
         ) {
             (Some(wkb), Some(pct_convex), Some(allow_holes)) => {
-                invoke_scalar(&wkb, pct_convex, allow_holes, &mut builder)?;
+                invoke_scalar(wkb, pct_convex, allow_holes, &mut builder)?;
                 builder.append_value([]);
             }
             _ => builder.append_null(),

c/sedona-geos/src/st_convexhull.rs

@@ -61,7 +61,7 @@ impl SedonaScalarKernel for STConvexHull {
         executor.execute_wkb_void(|maybe_wkb| {
             match maybe_wkb {
                 Some(wkb) => {
-                    invoke_scalar(&wkb, &mut builder)?;
+                    invoke_scalar(wkb, &mut builder)?;
                     builder.append_value([]);
                 }
                 _ => builder.append_null(),

c/sedona-geos/src/st_delaunaytriangles.rs

@@ -78,7 +78,7 @@ impl SedonaScalarKernel for STDelaunayTriangles {
         executor.execute_wkb_void(|maybe_geom| {
             match maybe_geom {
                 Some(geom) => {
-                    invoke_scalar(&geom, 0.0, false, &mut builder)?;
+                    invoke_scalar(geom, 0.0, false, &mut builder)?;
                     builder.append_value([]);
                 }
                 None => builder.append_null(),
@@ -125,7 +125,7 @@ impl SedonaScalarKernel for STDelaunayTrianglesWithTolerance {
         executor.execute_wkb_void(|maybe_geom| {
             match (maybe_geom, tol_iter.next().unwrap()) {
                 (Some(geom), Some(tol)) => {
-                    invoke_scalar(&geom, tol, false, &mut builder)?;
+                    invoke_scalar(geom, tol, false, &mut builder)?;
                     builder.append_value([]);
                 }
                 _ => builder.append_null(),
@@ -197,7 +197,7 @@ impl SedonaScalarKernel for STDelaunayTrianglesWithFlags {
                             ))
                         }
                     };
-                    invoke_scalar(&geom, tol, only_edges, &mut builder)?;
+                    invoke_scalar(geom, tol, only_edges, &mut builder)?;
                     builder.append_value([]);
                 }
                 _ => builder.append_null(),

c/sedona-geos/src/st_exteriorring.rs

@@ -71,7 +71,7 @@ impl SedonaScalarKernel for STExteriorRing {
         executor.execute_wkb_void(|maybe_geom| {
             match maybe_geom {
                 Some(geom) => {
-                    if invoke_scalar(&geom, &mut builder)? {
+                    if invoke_scalar(geom, &mut builder)? {
                         builder.append_value([]);
                     } else {
                         builder.append_null();

c/sedona-geos/src/st_isring.rs

@@ -59,7 +59,7 @@ impl SedonaScalarKernel for STIsRing {
         executor.execute_wkb_void(|maybe_wkb| {
             match maybe_wkb {
                 Some(wkb) => {
-                    builder.append_value(invoke_scalar(&wkb)?);
+                    builder.append_value(invoke_scalar(wkb)?);
                 }
                 _ => builder.append_null(),
             }