Skip to content

Commit 6231e94

Browse files
committed
Check in package-lock.json
Previously package-lock.json was gitignored. At one point the recommended practice was for libraries to not commit it, because committing it would prevent CI from detecting incompatible new versions of dependencies. That may have been good advice before it became common for attackers to publish malicious versions of legitimate packages via compromised maintainer accounts. Checking in a lockfile protects Jasmine developers against that threat by preventing new versions from being accidentaly installed.
1 parent 4459e94 commit 6231e94

2 files changed

Lines changed: 2273 additions & 1 deletion

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@ node_modules/
44
tags
55
sauce_connect.log
66
yarn.lock
7-
package-lock.json
87
.envrc

0 commit comments

Comments
 (0)