Question about setup_handlers()

[charliie-dev]

1. I would like to make sure that if I specify the sources in null-ls, will it got overwrite by require("mason-null-ls").setup_handlers()? Or it will respect the sources I set in null-ls?

2. What will require("mason-null-ls").setup_handlers() do if the source has multiple proposes? For example, markdownlint could be used for formatting and diagnostics, will setup_handlers setup sources for both usage?

Here's the snippets:

	require("mason-null-ls").setup({
		ensure_installed = require("core.settings").null_ls,
		automatic_installation = true,
		automatic_setup = true,
	})

	require("null-ls").setup({
		debug = false,
		update_in_insert = false,
		diagnostics_format = "[#{c}] #{m} (#{s})",
		-- NOTE: Users don't need to specify null-ls sources if using only default config.
		-- "mason-null-ls" will auto-setup for users.
		sources = {
			-- formatting
			btn.formatting.black.with({ extra_args = { "--fast" } }),
			btn.formatting.markdownlint,

			-- diagnostics
			btn.diagnostics.shellcheck.with({ diagnostics_format = "#{m} [#{c}]" }),
			btn.diagnostics.markdownlint.with({ extra_args = { "--disable MD033" } }),
		},
	})

	require("mason-null-ls").setup_handlers()

[jay-babu]

Hmmm, I am not actually sure what happens when null-ls.register is called for the same exact source. mason-null-ls will attempt to re-register though. I just don't know how null-ls handles that. However, I recommend you use either null-ls or mason-null-ls to set up and not both.

require("null-ls").setup()
require("mason-null-ls").setup(
    {
        ensure_installed = require("core.settings").null_ls,
        automatic_setup = true,
    }
)

require("mason-null-ls").setup_handlers(
    {
        shellcheck = function()
            null_ls.register(null_ls.builtins.diagnostics.shellcheck.with({diagnostics_format = "#{m} [#(c)]"}))
        end,
    }
)

2. Yes, it will setup everything available. you can override in the setup_handler if you do not want that

[charliie-dev]

Thanks for the fast reply!
So according to your suggestion, I rewrote the code as below, do I get your point?

	local null_ls = require("null-ls")
	local mason_null_ls = require("mason-null-ls")
	local btnf = null_ls.builtins.formatting
	local btnd = null_ls.builtins.diagnostics
	local null_reg = null_ls.register

	null_ls.setup({
		debug = false,
		update_in_insert = false,
		diagnostics_format = "[#{c}] #{m} (#{s})",
	})

	mason_null_ls.setup({
		ensure_installed = require("core.settings").null_ls,
		automatic_installation = true,
		automatic_setup = true,
	})

	-- NOTE: Users don't need to specify null-ls sources if using only default config.
	-- "mason-null-ls" will auto-setup for users.
	mason_null_ls.setup_handlers({
		black = function()
			null_reg(btnf.black.with({ extra_args = { "--fast" } }))
		end,
		markdownlint = function()
			null_reg(btnf.markdownlint)
			null_reg(btnd.markdownlint.with({ extra_args = { "--disable MD033" } }))
		end,
		shellcheck = function()
			null_reg(btnd.shellcheck.with({ diagnostics_format = "#{m} [#(c)]" }))
		end,
	})

[jay-babu]

Yes, that looks good