Fix several ts-expect-error

Author: Chris4942

src/apps/legacy/controllers/session/login/index.js

@@ -48,7 +48,7 @@ function authenticateUserByName(page, apiClient, url, username, password) {
 
         onLoginSuccessful(user.Id, result.AccessToken, apiClient, url);
     },
-    /** @param {{ status: number}} response */
+    /** @param {{ status: number }} response */
     function (response) {
         // @ts-expect-error
         page.querySelector('#txtManualPassword').value = '';
@@ -73,6 +73,7 @@ function authenticateUserByName(page, apiClient, url, username, password) {
  */
 function authenticateQuickConnect(apiClient, targetUrl) {
     const url = apiClient.getUrl('/QuickConnect/Initiate');
+    // TODO: I don't think the `true` in ajax() does anything here since it's never used in src/utils/fetch.js:84
     // @ts-expect-error
     apiClient.ajax({ type: 'POST', url }, true).then(res => res.json()).then(function (json) {
         if (!json.Secret || !json.Code) {
@@ -157,12 +158,9 @@ function onLoginSuccessful(id, accessToken, apiClient, url) {
 function showManualForm(context, showCancel, focusPassword) {
     // @ts-expect-error
     context.querySelector('.chkRememberLogin').checked = appSettings.enableAutoLogin();
-    // @ts-expect-error
-    context.querySelector('.manualLoginForm').classList.remove('hide');
-    // @ts-expect-error
-    context.querySelector('.visualLoginForm').classList.add('hide');
-    // @ts-expect-error
-    context.querySelector('.btnManual').classList.add('hide');
+    /** @type {Element} */ (context.querySelector('.manualLoginForm')).classList.remove('hide');
+    /** @type {Element} */ (context.querySelector('.visualLoginForm')).classList.add('hide');
+    /** @type {Element} */ (context.querySelector('.btnManual')).classList.add('hide');
 
     if (focusPassword) {
         // @ts-expect-error
@@ -173,11 +171,9 @@ function showManualForm(context, showCancel, focusPassword) {
     }
 
     if (showCancel) {
-        // @ts-expect-error
-        context.querySelector('.btnCancel').classList.remove('hide');
+        /** @type {Element} */ (context.querySelector('.btnCancel')).classList.remove('hide');
     } else {
-        // @ts-expect-error
-        context.querySelector('.btnCancel').classList.add('hide');
+        /** @type {Element} */ (context.querySelector('.btnCancel')).classList.add('hide');
     }
 }
 
@@ -235,8 +231,7 @@ function loadUserList(context, apiClient, users) {
         html += '</button>';
     }
 
-    // @ts-expect-error
-    context.querySelector('#divUsers').innerHTML = html;
+    /** @type {Element} */ (context.querySelector('#divUsers')).innerHTML = html;
 }
 
 /**
@@ -269,21 +264,17 @@ export default function (view, params) {
     }
 
     function showVisualForm() {
-        // @ts-expect-error
-        view.querySelector('.visualLoginForm').classList.remove('hide');
-        // @ts-expect-error
-        view.querySelector('.manualLoginForm').classList.add('hide');
-        // @ts-expect-error
-        view.querySelector('.btnManual').classList.remove('hide');
+        /** @type {Element} */ (view.querySelector('.visualLoginForm')).classList.remove('hide');
+        /** @type {Element} */ (view.querySelector('.manualLoginForm')).classList.add('hide');
+        /** @type {Element} */ (view.querySelector('.btnManual')).classList.remove('hide');
 
         import('components/autoFocuser').then(({ default: autoFocuser }) => {
             autoFocuser.autoFocus(view);
         });
     }
 
     // On user selected one of the user cards
-    // @ts-expect-error
-    view.querySelector('#divUsers').addEventListener('click', function (e) {
+    /** @type {Element} */ (view.querySelector('#divUsers')).addEventListener('click', function (e) {
         const card = dom.parentWithClass(/** @type {HTMLElement} */ (e.target), 'card');
         const cardContent = card ? card.querySelector('.cardContent') : null;
 
@@ -308,8 +299,7 @@ export default function (view, params) {
             }
         }
     });
-    // @ts-expect-error
-    view.querySelector('.manualLoginForm').addEventListener('submit', function (e) {
+    /** @type {Element} */ (view.querySelector('.manualLoginForm')).addEventListener('submit', function (e) {
         // @ts-expect-error
         appSettings.enableAutoLogin(view.querySelector('.chkRememberLogin').checked);
         authenticateUserByName(
@@ -322,25 +312,20 @@ export default function (view, params) {
         e.preventDefault();
         return false;
     });
-    // @ts-expect-error
-    view.querySelector('.btnForgotPassword').addEventListener('click', function () {
+    /** @type {Element} */ (view.querySelector('.btnForgotPassword')).addEventListener('click', function () {
         Dashboard.navigate('forgotpassword');
     });
-    // @ts-expect-error
-    view.querySelector('.btnCancel').addEventListener('click', showVisualForm);
-    // @ts-expect-error
-    view.querySelector('.btnQuick').addEventListener('click', function () {
+    /** @type {Element} */ (view.querySelector('.btnCancel')).addEventListener('click', showVisualForm);
+    /** @type {Element} */ (view.querySelector('.btnQuick')).addEventListener('click', function () {
         authenticateQuickConnect(getApiClient(), getTargetUrl());
         return false;
     });
-    // @ts-expect-error
-    view.querySelector('.btnManual').addEventListener('click', function () {
+    /** @type {Element} */ (view.querySelector('.btnManual')).addEventListener('click', function () {
         // @ts-expect-error
         view.querySelector('#txtManualName').value = '';
         showManualForm(view, true);
     });
-    // @ts-expect-error
-    view.querySelector('.btnSelectServer').addEventListener('click', function () {
+    /** @type {Element} */ (view.querySelector('.btnSelectServer')).addEventListener('click', function () {
         Dashboard.selectServer();
     });