Add tests for original title display preference

Author: tdimov93

src/apps/legacy/features/search/constants/queryOptions.test.ts

@@ -0,0 +1,10 @@
+import { ItemFields } from '@jellyfin/sdk/lib/generated-client/models/item-fields';
+import { describe, expect, it } from 'vitest';
+
+import { QUERY_OPTIONS } from './queryOptions';
+
+describe('QUERY_OPTIONS', () => {
+    it('should include OriginalTitle field', () => {
+        expect(QUERY_OPTIONS.fields).toContain(ItemFields.OriginalTitle);
+    });
+});

src/components/itemHelper.test.js

@@ -0,0 +1,39 @@
+import { describe, expect, it, vi } from 'vitest';
+
+import { getDisplayName } from './itemHelper';
+
+vi.mock('./apphost', () => ({ appHost: { supports: vi.fn() } }));
+vi.mock('lib/globalize', () => ({ default: { translate: vi.fn((key, ...args) => args[0] ?? key) } }));
+vi.mock('lib/jellyfin-apiclient', () => ({ ServerConnections: {} }));
+vi.mock('utils/jellyfin-apiclient/compat', () => ({ toApi: vi.fn() }));
+vi.mock('scripts/settings/userSettings', () => ({ shouldUseOriginalTitles: vi.fn() }));
+
+import { shouldUseOriginalTitles } from 'scripts/settings/userSettings';
+
+describe('getDisplayName', () => {
+    describe('shouldUseOriginalTitles preference', () => {
+        it('should return OriginalTitle when preference is enabled and OriginalTitle is available', () => {
+            shouldUseOriginalTitles.mockReturnValue(true);
+            const item = { Type: 'Movie', Name: 'Spirited Away', OriginalTitle: '千と千尋の神隠し' };
+            expect(getDisplayName(item)).toBe('千と千尋の神隠し');
+        });
+
+        it('should return Name when preference is enabled but OriginalTitle is not set', () => {
+            shouldUseOriginalTitles.mockReturnValue(true);
+            const item = { Type: 'Movie', Name: 'Spirited Away' };
+            expect(getDisplayName(item)).toBe('Spirited Away');
+        });
+
+        it('should return Name when preference is disabled even if OriginalTitle is available', () => {
+            shouldUseOriginalTitles.mockReturnValue(false);
+            const item = { Type: 'Movie', Name: 'Spirited Away', OriginalTitle: '千と千尋の神隠し' };
+            expect(getDisplayName(item)).toBe('Spirited Away');
+        });
+
+        it('should return EpisodeTitle for Program regardless of OriginalTitle when preference is enabled', () => {
+            shouldUseOriginalTitles.mockReturnValue(true);
+            const item = { Type: 'Program', Name: 'Show Name', OriginalTitle: 'Original Show Name', EpisodeTitle: 'Episode Title' };
+            expect(getDisplayName(item)).toBe('Episode Title');
+        });
+    });
+});

src/scripts/settings/userSettings.test.js

@@ -0,0 +1,48 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+
+vi.mock('../../utils/events.ts', () => ({ default: { trigger: vi.fn() } }));
+vi.mock('../browser', () => ({ default: {} }));
+vi.mock('./appSettings', () => ({ default: { get: vi.fn(), set: vi.fn() } }));
+
+import appSettings from './appSettings';
+import { UserSettings } from './userSettings';
+
+describe('UserSettings', () => {
+    let settings;
+
+    beforeEach(() => {
+        settings = new UserSettings();
+        vi.clearAllMocks();
+    });
+
+    describe('shouldUseOriginalTitles', () => {
+        it('reads from server display preferences when they are loaded', () => {
+            settings.displayPrefs = { CustomPrefs: { useOriginalTitles: 'true' } };
+
+            expect(settings.shouldUseOriginalTitles()).toBe(true);
+            expect(appSettings.get).not.toHaveBeenCalled();
+        });
+
+        it('reads false from server display preferences when set to false', () => {
+            settings.displayPrefs = { CustomPrefs: { useOriginalTitles: 'false' } };
+
+            expect(settings.shouldUseOriginalTitles()).toBe(false);
+            expect(appSettings.get).not.toHaveBeenCalled();
+        });
+
+        it('server preference takes precedence over local storage value', () => {
+            settings.displayPrefs = { CustomPrefs: { useOriginalTitles: 'true' } };
+            appSettings.get.mockReturnValue('false');
+
+            expect(settings.shouldUseOriginalTitles()).toBe(true);
+        });
+
+        it('falls back to local storage when server preferences are not loaded', () => {
+            settings.displayPrefs = null;
+            appSettings.get.mockReturnValue('true');
+
+            expect(settings.shouldUseOriginalTitles()).toBe(true);
+            expect(appSettings.get).toHaveBeenCalled();
+        });
+    });
+});

src/utils/items.test.ts

@@ -0,0 +1,41 @@
+import { ItemFields } from '@jellyfin/sdk/lib/generated-client/models/item-fields';
+import { ImageType } from '@jellyfin/sdk/lib/generated-client/models/image-type';
+import { ItemSortBy } from '@jellyfin/sdk/lib/generated-client/models/item-sort-by';
+import { SortOrder } from '@jellyfin/sdk/lib/generated-client/models/sort-order';
+import { describe, expect, it, vi } from 'vitest';
+
+import { LibraryTab } from 'types/libraryTab';
+import { ViewMode } from 'types/library';
+import type { LibraryViewSettings } from 'types/library';
+
+import { getFieldsQuery } from './items';
+
+vi.mock('scripts/settings/userSettings');
+vi.mock('components/layoutManager', () => ({ default: {} }));
+
+const baseSettings: LibraryViewSettings = {
+    SortBy: ItemSortBy.SortName,
+    SortOrder: SortOrder.Ascending,
+    StartIndex: 0,
+    CardLayout: false,
+    ImageType: ImageType.Primary,
+    ViewMode: ViewMode.GridView,
+    ShowTitle: true
+};
+
+describe('getFieldsQuery', () => {
+    it('should include OriginalTitle field when useOriginalTitles is true', () => {
+        const result = getFieldsQuery(LibraryTab.Movies, baseSettings, true);
+        expect(result.fields).toContain(ItemFields.OriginalTitle);
+    });
+
+    it('should not include OriginalTitle field when useOriginalTitles is false', () => {
+        const result = getFieldsQuery(LibraryTab.Movies, baseSettings, false);
+        expect(result.fields).not.toContain(ItemFields.OriginalTitle);
+    });
+
+    it('should not include OriginalTitle field when useOriginalTitles is not provided', () => {
+        const result = getFieldsQuery(LibraryTab.Movies, baseSettings);
+        expect(result.fields).not.toContain(ItemFields.OriginalTitle);
+    });
+});